fix(batch): accept empty structured results - #2473
Closed
hsusul wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Consolidated and shipped in #2495. Closing this focused patch as superseded; thank you for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow valid empty structured objects in batch results to reach Pydantic validation.
Problem
BatchProcessor.parse_results()treats an extracted{}response as anextraction failure. Models whose fields have defaults therefore receive a
BatchErrorinstead of a successfully validated result.This affects both OpenAI JSON-schema batch responses and Anthropic tool-use
batch responses.
Root cause
The parser used a truthiness check for
extracted_data, conflating an emptydictionary with the
Nonesentinel returned when no structured result couldbe extracted.
Fix
Check explicitly for
None. Empty dictionaries are now validated normally,while absent and malformed results retain the existing error behavior.
Test plan
{}Compatibility considerations
This is backwards-compatible. Only valid empty mappings change behavior;
missing or malformed results continue to produce
BatchError.Issue ticket number and link
N/A — independently discovered; no matching issue found