fix(docs): correct Vertex AI migration, update Known Limitations, clarify Google providers - #2343
Closed
junqigif wants to merge 1 commit into
Closed
fix(docs): correct Vertex AI migration, update Known Limitations, clarify Google providers#2343junqigif wants to merge 1 commit into
junqigif wants to merge 1 commit into
Conversation
…rify Google providers - Fix Vertex AI migration docs that contradicted the code (code says `vertexai/` prefix is deprecated, docs said the opposite) - Update Known Limitations section (Union check is no-op stub, Enum and Optional types now work) - Clarify relationship between google/, vertexai/, and gemini/ provider prefixes in from_provider - Update all vertex.md examples from deprecated vertexai/ prefix to google/<model> + vertexai=True Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
jordandunmire97-ai
approved these changes
Jun 28, 2026
jordandunmire97-ai
approved these changes
Jun 28, 2026
Collaborator
|
Thanks for taking on the Google docs cleanup. I selected #2389 as the immediate merge candidate for #2289 because it fixes the same mode/limitation/syntax problems with a smaller and cleaner patch. This PR still has some potentially useful provider-prefix clarification, but it also makes broader Vertex example rewrites and adds date-stamped limitation language, so I would not merge it as-is. If you want to continue it, the best next version would be a narrower follow-up after #2389 lands, focused only on the remaining provider-prefix / Vertex migration guidance. |
Closed
3 tasks
jordandunmire97-ai
approved these changes
Jun 29, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three remaining items from issue #2289 (Google documentation issues):
Fix Vertex AI migration docs — The migration guides in
google.mdandvertex.mdcontradicted the code. The code (auto_client.py) saysvertexai/<model>is deprecated and users should usegoogle/<model>withvertexai=True, but the docs said the opposite.Update Known Limitations — Removed outdated claims about Enum types not working and Union types being unsupported. The
verify_no_unionscheck is a no-op stub (always returnsTrue), and Optional types work correctly.Clarify Google provider relationship — Added a clear explanation of the three provider prefixes (
google/,vertexai/,gemini/) and which one is current vs deprecated.Files changed
docs/integrations/google.md— Provider prefix clarity, Known Limitations update, fixed Vertex AI migrationdocs/integrations/vertex.md— Updated all examples from deprecatedvertexai/prefix togoogle/<model>+vertexai=True, fixed migration docs, removed old SDK imports from examplesFixes #2289
🤖 Generated with Claude Code