Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ This file provides guidance to coding agents working in this repository.
- See `docs/architecture/nx-workspace-boundaries.md` for the current Nx tag and alias policy.
- Keep `nx` and every official `@nx/*` package on the same exact version; run
`pnpm run deps:nx:validate` after dependency updates.
- Vite `7.3.5`, resolved through Angular's build tooling, is patched with
- Vite `7.3.6`, resolved through Angular's build tooling, is patched with
bounded transform prefilters and the upstream precise matchers in
`patches/vite@7.3.5.patch`. Keep the patch until supported Angular tooling
`patches/vite@7.3.6.patch`. Keep the patch until supported Angular tooling
resolves a Vite version containing the fix, and run `pnpm run deps:vite:test`
after related dependency updates.
- A directory holding files consumed by other projects must be an Nx project.
Expand Down
4 changes: 2 additions & 2 deletions CLAUDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,9 @@ pnpm nx show projects
- See `docs/architecture/nx-workspace-boundaries.md` for the current Nx tag and alias policy.
- Keep `nx` and every official `@nx/*` package on the same exact version; run
`pnpm run deps:nx:validate` after dependency updates.
- Vite `7.3.5`, resolved through Angular's build tooling, is patched with
- Vite `7.3.6`, resolved through Angular's build tooling, is patched with
bounded transform prefilters and the upstream precise matchers in
`patches/vite@7.3.5.patch`. Keep the patch until supported Angular tooling
`patches/vite@7.3.6.patch`. Keep the patch until supported Angular tooling
resolves a Vite version containing the fix, and run `pnpm run deps:vite:test`
after related dependency updates.
- A directory holding files consumed by other projects must be an Nx project.
Expand Down
6 changes: 3 additions & 3 deletions docs/architecture/nx-workspace-boundaries.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,20 +52,20 @@ resulting PR runs the full CI pipeline.

## Vite Dev-Server Patch

Angular's development builder currently resolves Vite `7.3.5`. That release's
Angular's development builder currently resolves Vite `7.3.6`. That release's
asset and worker transform prefilters can catastrophically backtrack on a large
generated chunk containing unrelated `new URL...` expressions while searching
for a valid `new URL(..., import.meta.url)` construct. The Electron development
server can then fail a lazy chunk request with `Maximum call stack size
exceeded`, even though static builds succeed because they do not pass emitted
chunks through Vite's request-time plugin container.

`patches/vite@7.3.5.patch` backports Vite's upstream precise-matcher fix from
`patches/vite@7.3.6.patch` backports Vite's upstream precise-matcher fix from
[vitejs/vite#21800](https://github.com/vitejs/vite/pull/21800). Bounded
prefilters keep the request-time scan linear while allowing comment-bearing
asset and worker expressions to reach the precise matcher after Vite strips
comments. Keep the patch while the supported Angular toolchain resolves Vite
`7.3.5`; remove it only after the resolved Vite contains the upstream fix. Run
`7.3.6`; remove it only after the resolved Vite contains the upstream fix. Run
the regression check after any related manifest or lockfile update:

```bash
Expand Down
48 changes: 24 additions & 24 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -81,16 +81,16 @@
"private": true,
"packageManager": "pnpm@10.33.0+sha512.10568bb4a6afb58c9eb3630da90cc9516417abebd3fabbe6739f0ae795728da1491e9db5a544c76ad8eb7570f5c4bb3d6c637b2cb41bfdcdb47fa823c8649319",
"dependencies": {
"@angular/animations": "21.2.17",
"@angular/animations": "21.2.19",
"@angular/cdk": "21.2.14",
"@angular/common": "21.2.17",
"@angular/compiler": "21.2.17",
"@angular/core": "21.2.17",
"@angular/forms": "21.2.17",
"@angular/common": "21.2.19",
"@angular/compiler": "21.2.19",
"@angular/core": "21.2.19",
"@angular/forms": "21.2.19",
"@angular/material": "21.2.14",
"@angular/platform-browser": "21.2.17",
"@angular/platform-browser-dynamic": "21.2.17",
"@angular/router": "21.2.17",
"@angular/platform-browser": "21.2.19",
"@angular/platform-browser-dynamic": "21.2.19",
"@angular/router": "21.2.19",
"@ngrx/effects": "21.1.1",
"@ngrx/entity": "21.1.1",
"@ngrx/router-store": "21.1.1",
Expand Down Expand Up @@ -125,25 +125,25 @@
"zone.js": "~0.16.2"
},
"devDependencies": {
"@angular-devkit/core": "21.2.17",
"@angular-devkit/schematics": "21.2.17",
"@angular-devkit/core": "21.2.19",
"@angular-devkit/schematics": "21.2.19",
"@angular-eslint/builder": "21.3.1",
"@angular-eslint/eslint-plugin": "21.3.1",
"@angular-eslint/eslint-plugin-template": "21.3.1",
"@angular-eslint/schematics": "21.3.1",
"@angular-eslint/template-parser": "21.3.1",
"@angular/build": "21.2.17",
"@angular/cli": "21.2.17",
"@angular/common": "21.2.17",
"@angular/compiler": "21.2.17",
"@angular/compiler-cli": "21.2.17",
"@angular/core": "21.2.17",
"@angular/forms": "21.2.17",
"@angular/language-service": "21.2.17",
"@angular/platform-browser": "21.2.17",
"@angular/platform-browser-dynamic": "21.2.17",
"@angular/router": "21.2.17",
"@angular/service-worker": "21.2.17",
"@angular/build": "21.2.19",
"@angular/cli": "21.2.19",
"@angular/common": "21.2.19",
"@angular/compiler": "21.2.19",
"@angular/compiler-cli": "21.2.19",
"@angular/core": "21.2.19",
"@angular/forms": "21.2.19",
"@angular/language-service": "21.2.19",
"@angular/platform-browser": "21.2.19",
"@angular/platform-browser-dynamic": "21.2.19",
"@angular/router": "21.2.19",
"@angular/service-worker": "21.2.19",
"@astrojs/mdx": "4.3.13",
"@astrojs/sitemap": "3.7.3",
"@astrojs/tailwind": "6.0.2",
Expand All @@ -169,7 +169,7 @@
"@nx/web": "22.7.2",
"@nx/workspace": "22.7.2",
"@playwright/test": "^1.62.0",
"@schematics/angular": "21.2.9",
"@schematics/angular": "21.2.19",
"@swc-node/register": "1.12.1",
"@swc/core": "1.15.46",
"@swc/helpers": "0.5.23",
Expand Down Expand Up @@ -252,7 +252,7 @@
},
"patchedDependencies": {
"nx-electron@22.0.0": "patches/nx-electron@22.0.0.patch",
"vite@7.3.5": "patches/vite@7.3.5.patch"
"vite@7.3.6": "patches/vite@7.3.6.patch"
Comment thread
4gray marked this conversation as resolved.
Comment thread
4gray marked this conversation as resolved.
}
}
}
1 change: 0 additions & 1 deletion patches/vite@7.3.5.patch → patches/vite@7.3.6.patch
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
diff --git a/dist/node/chunks/config.js b/dist/node/chunks/config.js
index 9a45043275249a25101fd7991ffcfc316478840e..5435b17de9ca65b64a8abacb609b75587226b106 100644
--- a/dist/node/chunks/config.js
+++ b/dist/node/chunks/config.js
@@ -27667,7 +27667,8 @@ async function getWorkerType(raw, clean, i$1) {
Expand Down
Loading
Loading