fix: make patch motion groups the sum of the underlying frame data - #1359
Merged
Merged
Conversation
fullerjamesr
force-pushed
the
motiongroup
branch
from
August 14, 2026 19:26
13301a2 to
a2f7c7a
Compare
Member
|
Oops! You are right. This was a terrible mistake. Thank you very much for catching it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed while playing around with motion correcting movies with intentionally inadvisably high fractionation that grouping was not having the expected result. I think there is a bug here where currently a patch's group actually just ends up set to the contents of the last frame in the group, whereas I assume what I have in this pull request was/is the actual intent: sum the contents of the frames within each group/patch?
When I tested this change, grouping gave better/more successful local motion results than the existing code.