[spike] Support standing-up clusters in Terraform (for AWS) - #8642
Draft
agoose77 wants to merge 9 commits into
Draft
[spike] Support standing-up clusters in Terraform (for AWS)#8642agoose77 wants to merge 9 commits into
agoose77 wants to merge 9 commits into
Conversation
agoose77
marked this pull request as draft
June 29, 2026 15:44
Contributor
|
Merging this PR will trigger the following deployment actions. Support deploymentsNo support upgrades will be triggered Staging deployments
Production deployments
|
agoose77
changed the title
agoose77
changed the title
Member
|
This was one of the reasons i moved us to using managed nodegroups! If this works, great :) But do timebox yourself, and make sure upgrades are possible |
Member
|
Also big +1 for just using the terraform resources directly rather than using a module like https://registry.terraform.io/modules/terraform-aws-modules/eks/aws/latest. Our needs are reasonably simple so this is ok. |
agoose77
force-pushed
the
main
branch
2 times, most recently
from
July 6, 2026 10:30
525365c to
ab6687e
Compare
yuvipanda
requested changes
Jul 24, 2026
| role = aws_iam_role.node[0].name | ||
| } | ||
|
|
||
| resource "aws_launch_template" "core" { |
Member
There was a problem hiding this comment.
This is setting up an unmanaged nodegroup, right? We should use https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/eks_node_group instead which should drastically simplify this
Contributor
Author
There was a problem hiding this comment.
This should be setting up managed node groups. We need to specify launch templates so that we can patch the kubelet config.
That said, I haven't tested this yet — I mainly tested that the plan looked reasonable — this was a short spike to build out the infra.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR recreates the neurohackademy cluster.
I generally dislike the need to run
eksctl— it's slow, and a separate workflow from our other clusters. I noticed #1924 today, and I think it still holds true.Therefore, I'm taking this opportunity to rebuild neurohackademy using Terraform.
To Do