[TECH] Ne pas stocker de timestamp pour la révocation de session (PIX-24133) by nlepage · Pull Request #17394 · 1024pix/pix

nlepage · 2026-09-04T07:35:50Z

☀️ Problème

Une session est révoquée définitivement, donc il n’est pas nécessaire de stocker un timestamp de fin de révocation.

⛱️ Proposition

Cesser de stocker le timstamp de révocation de session, on stocke une chaîne vide à la place, la présence de la clé est suffisante.

🧴 Remarques

N/A

🏊 Pour tester

Vérifier qu’il n’y a pas de régression au niveau de la révocation de session avec le feature toggle actif.

Le feature toggle est actif sur la RA.

pix-bot-github · 2026-09-04T07:35:57Z

Choisir les applications à déployer :

Important

N'oubliez pas de déployer l'API pour pouvoir accéder aux fronts et/ou à l’API MaDDo.

lego-technix

✅ Lu et testé fonctionnellement avec succès avec Firefox 🦊 et Linux 🐧

Expiration was implemented incoherently in various methods. InMemoryKeyValueStorage is now used only in unit tests which makes implementing expiration non necessary.

RevokedUserAccess model

RevokedUserAccess model Co-Authored-By: "LEGO Technix" <109212476+lego-technix@users.noreply.github.com>

Co-Authored-By: "LEGO Technix" <109212476+lego-technix@users.noreply.github.com>

Co-Authored-By: "Guillaume Lagorce" <guillaume.lagorce@pix.fr>

# [5.499.0](v5.498.1...v5.499.0) (2026-09-10) ### 🚀 Amélioration - [#17418](#17418) Ajouter l'ID de la catégorie à la modification d'organisations en masse (PIX-23565) - [#17452](#17452) Ajouter un sélecteur de catégorie sur la fiche d'édition d'une organisation (PIX-23563) - [#17429](#17429) migration pour remettre des contraintes "not nullable" supprimés par inadvertance (PIX-24132) - [#17404](#17404) Récupérer les CGU de l'utilisateur de Pix Certif en passant par le nouveau modèle (PIX-22441) ### 🐛 Correction - [#17460](#17460) Ne pas jeter d'erreur 500 lors de la concurrence de création d'invitation à un CDC (PIX-24219) ### 🏗️ Tech - [#17410](#17410) Créer un script permettant l'ajout des ids de contenus formatifs pour la mise en avant en fin de parcours (PIX-24009). - [#17070](#17070) Déplacer le pré-handler d'Assessment dans shared - [#17394](#17394) Ne pas stocker de timestamp pour la révocation de session (PIX-24133) ### ⬆️ Montée de version - [#17419](#17419) Update dependency @1024pix/pix-ui to ^68.1.1 (mon-pix) - [#17462](#17462) Update dependency @1024pix/pix-ui to ^68.1.3 (junior) - [#17428](#17428) Update dependency @testing-library/user-event to ^14.6.6 (mon-pix) - [#17449](#17449) Update dependency @testing-library/user-event to ^14.6.7 (mon-pix) - [#17445](#17445) Update dependency @xmldom/xmldom to >=0.9.12 (admin) [SECURITY] - [#17446](#17446) Update dependency @xmldom/xmldom to >=0.9.12 (certif) [SECURITY] - [#17369](#17369) Update dependency js-yaml to v5.2.2 [SECURITY] - [#17442](#17442) Update dependency nodemailer to v9.1.1 [SECURITY] - [#17447](#17447) Update dependency protobufjs to >=8.6.6 (api) [SECURITY] - [#17440](#17440) Update dependency vitest to v4.1.11 [SECURITY]

pix-service · 2026-09-10T10:22:16Z

🎉 This PR is included in version 5.499.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

nlepage self-assigned this Sep 4, 2026

nlepage added the team-acces label Sep 4, 2026

nlepage requested a review from a team as a code owner September 4, 2026 07:35

lego-technix reviewed Sep 4, 2026

View reviewed changes

Comment thread api/src/identity-access-management/domain/models/RevokedUserAccess.js Outdated

lego-technix reviewed Sep 4, 2026

View reviewed changes

Comment thread api/src/shared/infrastructure/key-value-storages/InMemoryKeyValueStorage.js

lego-technix reviewed Sep 4, 2026

View reviewed changes

Comment thread ...src/identity-access-management/infrastructure/repositories/revoked-user-access.repository.js Outdated

nlepage force-pushed the pix-24133-revoke-session-storage branch from c487f84 to cd164d0 Compare September 4, 2026 13:03

nlepage requested review from a team as code owners September 4, 2026 13:03

nlepage force-pushed the pix-24133-revoke-session-storage branch from cd164d0 to 5f0b6fe Compare September 4, 2026 13:12

Base automatically changed from pix-24078-logout-route to dev September 7, 2026 07:58

nlepage force-pushed the pix-24133-revoke-session-storage branch from 7746025 to a257136 Compare September 7, 2026 07:58

nlepage marked this pull request as draft September 7, 2026 08:17

nlepage requested review from a team and removed request for a team September 7, 2026 08:17

nlepage force-pushed the pix-24133-revoke-session-storage branch from a257136 to 92b16f3 Compare September 7, 2026 09:18

nlepage marked this pull request as ready for review September 7, 2026 09:18

nlepage force-pushed the pix-24133-revoke-session-storage branch from 92b16f3 to 8e83de9 Compare September 7, 2026 09:37

lego-technix reviewed Sep 7, 2026

View reviewed changes

Comment thread ...src/identity-access-management/infrastructure/repositories/revoked-user-access.repository.js Outdated

lego-technix approved these changes Sep 7, 2026

View reviewed changes

nlepage force-pushed the pix-24133-revoke-session-storage branch 4 times, most recently from 9892e7d to f460543 Compare September 9, 2026 13:33

sr(api): removes expiration from InMemoryKeyValueStorage

0d631c1

Expiration was implemented incoherently in various methods. InMemoryKeyValueStorage is now used only in unit tests which makes implementing expiration non necessary.

nlepage and others added 6 commits September 9, 2026 16:21

sr(api): makes in memory key value storage actual unit tests

d6d016d

refactor(api): removes timestamps for revoked sessions in

a01e714

RevokedUserAccess model

refactor(api): stops storing timestamp for revoked sessions

84e9d7b

refactor(api): renames revokedSessions to revokedSessionIds in

dc6b36f

RevokedUserAccess model Co-Authored-By: "LEGO Technix" <109212476+lego-technix@users.noreply.github.com>

tech(api): moves revokeSession above revokeAll

98d7716

Co-Authored-By: "LEGO Technix" <109212476+lego-technix@users.noreply.github.com>

fix(api): synchronous feature toggles could be outdated

ce758d6

Co-Authored-By: "Guillaume Lagorce" <guillaume.lagorce@pix.fr>

nlepage force-pushed the pix-24133-revoke-session-storage branch from f460543 to ce758d6 Compare September 9, 2026 14:21

Libouk approved these changes Sep 9, 2026

View reviewed changes

nlepage added this pull request to the merge queue Sep 9, 2026

Merged via the queue into dev with commit 05b37d3 Sep 9, 2026
10 checks passed

nlepage deleted the pix-24133-revoke-session-storage branch September 9, 2026 22:57

pix-service added the released label Sep 10, 2026

Navigation Menu

Uh oh!

[TECH] Ne pas stocker de timestamp pour la révocation de session (PIX-24133) - #17394

[TECH] Ne pas stocker de timestamp pour la révocation de session (PIX-24133)#17394
nlepage merged 7 commits into
devfrom
pix-24133-revoke-session-storage

nlepage commented Sep 4, 2026 •

edited

Loading

Uh oh!

pix-bot-github commented Sep 4, 2026 •

edited by nlepage

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lego-technix left a comment

Uh oh!

Uh oh!

pix-service commented Sep 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

nlepage commented Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

☀️ Problème

⛱️ Proposition

🧴 Remarques

🏊 Pour tester

Uh oh!

pix-bot-github commented Sep 4, 2026 • edited by nlepage Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lego-technix left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pix-service commented Sep 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nlepage commented Sep 4, 2026 •

edited

Loading

pix-bot-github commented Sep 4, 2026 •

edited by nlepage

Loading