Skip to content

fix: add actionable hints for chain out of sync errors (#2363) #2375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ayaanoncrypto wants to merge 1 commit into
base: develop
Choose a base branch
from
+6 −6
Open

fix: add actionable hints for chain out of sync errors (#2363) #2375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/geth/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ var (
}
)

var app = flags.NewApp("the go-ethereum command line interface")
var app = flags.NewApp("the go-ethereum command line interface. Check for updates at https://github.com/0xPolygon/bor/releases")

func init() {
// Initialize the CLI app and start Geth
Expand Down
2 changes: 1 addition & 1 deletion eth/bor_checkpoint_verifier.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ func borVerify(ctx context.Context, eth *Ethereum, handler *ethHandler, start ui
head := currentBlock.Number.Uint64()

if head < end {
log.Debug(fmt.Sprintf("Current head block behind incoming %s block", str), "head", head, "end block", end)
log.Info(fmt.Sprintf("Current head block behind incoming %s block", str), "head", head, "end block", end, "hint", "Check for updates if sync is stalled.")
return hash, errChainOutOfSync
}

Expand Down
8 changes: 4 additions & 4 deletions eth/handler_bor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,9 @@ func (h *ethHandler) handleWhitelistCheckpoint(ctx context.Context, checkpoint *
hash, err := verifier.verify(ctx, eth, h, checkpoint.StartBlock, checkpoint.EndBlock, checkpoint.RootHash.String()[2:], true)
if err != nil {
if errors.Is(err, errChainOutOfSync) {
log.Info("Whitelisting checkpoint deferred", "err", err)
log.Info("Whitelisting checkpoint deferred. Check for updates if sync is stalled.", "err", err)
} else {
log.Warn("Failed to whitelist checkpoint", "err", err)
log.Warn("Failed to whitelist checkpoint. Check for updates if sync is stalled.", "err", err)
}
return common.Hash{}, err
}
Expand Down Expand Up @@ -91,9 +91,9 @@ func (h *ethHandler) handleMilestone(ctx context.Context, eth *Ethereum, milesto
_, err := verifier.verify(ctx, eth, h, milestone.StartBlock, milestone.EndBlock, milestone.Hash.String()[2:], false)
if err != nil {
if errors.Is(err, errChainOutOfSync) {
log.Info("Whitelisting milestone deferred", "err", err)
log.Info("Whitelisting milestone deferred. Check for updates if sync is stalled.", "err", err)
} else {
log.Warn("Failed to whitelist milestone", "err", err)
log.Warn("Failed to whitelist milestone. Check for updates if sync is stalled.", "err", err)
}
h.downloader.UnlockSprint(milestone.EndBlock)
}
Expand Down