Repository navigation
docs(rig-cli): help-agents says a settings.toml the launcher can't read exits 1 - #3134
Merged
Merged
Conversation
7 of 10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs(rig-cli): help-agents says a settings.toml the launcher can't read exits 1
Description
rig help-agentssaid aRIG_HOME/settings.tomlthat cannot be read, is not TOML or has a table that does not read exits 2. Only a plugin's own settings table is refused by the agent with 2. The launcher reads the file and its[plugins]table itself before any agent exists (config::chosen, thenFailedAt::Settingsinrig-cli/src/build.rs), andmainprintserror: …and exits 1, with no JSON line. The text now says so, inrig help-agentsand in the user guide (docs/agent.md, "Without the terminal view"), which said the same. Text change only.Found by the 2026-11-07 architecture audit (finding f-8).
What users see change
rig help-agentsanddocs/agent.mdsay that asettings.tomlthat cannot be read, is not TOML, or has a[plugins]table that does not read makes rig exit 1 with the reason on stderr and no JSON line, and that a plugin's own settings table that does not read still exits 2.Changelog
rig help-agentsanddocs/agent.mdgive the right exit code (1, not 2) for asettings.tomlthe launcher cannot read.Migration
None
Type of change
Testing
crates/rig-cli/src/main.rs(error:andExitCode::FAILURE),crates/rig-cli/src/build.rs(FailedAt::Settings),crates/rig-cli/src/run.rs(rebuild) andcrates/rig-harness-protocol/src/config.rs(chosen).rig -p --json hi </dev/nullwith a freshRIG_HOME): settings[(not TOML),[plugins]\nenable = 3(bad[plugins]table) and a duplicate key each exit 1, printerror: <path>…on stderr and nothing on stdout.cargo xtask verify --affected --base origin/mainat this head.Checklist:
CHANGELOG.mdorMIGRATING.md(they are generated at release)Notes
Lines: production 0, docs +10 −6, tests 0.