Skip to content

test: fund accounts in one transaction and raise integration concurrency - #2467

Merged
igamigo merged 25 commits into
jmunoz-integration-test-with-feesfrom
igamigo-improve-tests-startup
Aug 31, 2026
Merged

test: fund accounts in one transaction and raise integration concurrency#2467
igamigo merged 25 commits into
jmunoz-integration-test-with-feesfrom
igamigo-improve-tests-startup

Conversation

@igamigo

@igamigo igamigo commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator
  • Speeds up CI funding by paying all accounts in one transaction (goes from ~76 min to ~51 min).
  • Fixes fee handling in the client: custom-script notes sync correctly (for this we basically remove the fee notes from the post-tx screening process), fee conversion info is handled by auth type without panics, empty auth args no longer suppress it, and TransactionRequest::with_auth_arg supports custom commitments.
  • Adjusts wallets - we only need a handful as it becomes a bottleneck as long as it's close ot the amount of concurrent tests (or to be more precise, the amount of ongoing funding txs)
  • Fixes flaky tests by polling for NTXs, deploying accounts when required, and making funder setup/commit handling reliable.
  • Cleans up test infrastructure: typed genesis.toml, CI node logs, workspace toml, and correct AggLayer fee denomination.
  • Pushes agglayer tests to their own job

igamigo added 16 commits August 28, 2026 19:01
Batches the funder's payments and the deploys' commit wait, and lifts the
integration test group's thread cap from 2 to 4.
…n uses

Extracts the native conversion info decision into one helper shared by
transaction execution and note screening.
At 4 the per-test durations inflate ~1.65x and the network-transaction
tests fail, so the rayon provers are outrunning the runner's cores.
… faucet

The genesis accounts named the mock chain's fee faucet, so the ntx-builder
could not execute their transactions and their notes went unconsumed.
Serializes a GenesisConfig with serde instead of concatenating TOML by
hand, so adding fields no longer means escaping braces in a format string.
An account's funding note is held until it next transacts and consumed
there, so one transaction deploys the account, funds it and does the
test's work instead of a dedicated deploy plus a wait for it.
The CLI drives accounts from its own process, so the funds have to be in
the vault, not in a note this client holds. The funder also waits for its
payment to commit before releasing the wallet.
The node builds them on its own schedule, which stretches with load.
Tests that execute without submitting bypassed the injection and hit the
fee with an empty vault.
@igamigo
igamigo marked this pull request as ready for review August 31, 2026 02:05
@igamigo
igamigo merged commit a771b6d into jmunoz-integration-test-with-fees Aug 31, 2026
19 checks passed
@igamigo
igamigo deleted the igamigo-improve-tests-startup branch August 31, 2026 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant