Skip to content

fix(rpc): avoid retrying unavailable submissions - #2442

Open
huklaa wants to merge 1 commit into
0xMiden:nextfrom
huklaa:fix-2441-submission-retry-policy
Open

fix(rpc): avoid retrying unavailable submissions#2442
huklaa wants to merge 1 commit into
0xMiden:nextfrom
huklaa:fix-2441-submission-retry-policy

Conversation

@huklaa

@huklaa huklaa commented Aug 25, 2026

Copy link
Copy Markdown

Summary

Fixes #2441.

Transaction submission RPCs are not safe to retry on Unavailable: the node may already have accepted the first request before the response was lost, so retrying can turn a successful submission into an apparent application-level rejection.

This change makes the existing retry policy endpoint-aware:

  • SubmitProvenTx and SubmitProvenBatch retry ResourceExhausted only;
  • read-only RPCs keep retrying both ResourceExhausted and Unavailable;
  • focused tests cover both submission-policy branches;
  • the Unreleased changelog documents the behavior change.

Testing

cargo test -p miden-client rpc::tonic_client::retry --lib

The branch is based on next and contains one focused commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't retry transaction submissions on Unavailable

1 participant