feat(validator): paginated admin transaction listing - #2532
Open
sergerad wants to merge 1 commit into
Open
Conversation
This was referenced Aug 31, 2026
sergerad
force-pushed
the
sergerad-validator-admin-list
branch
from
August 31, 2026 02:13
d32b468 to
e4c2962
Compare
sergerad
force-pushed
the
sergerad-validator-admin-list
branch
from
August 31, 2026 02:28
e4c2962 to
9c26542
Compare
sergerad
marked this pull request as ready for review
August 31, 2026 02:32
sergerad
force-pushed
the
sergerad-validator-admin-list
branch
from
August 31, 2026 02:50
9c26542 to
e1078a4
Compare
sergerad
force-pushed
the
sergerad-validator-admin-list
branch
from
August 31, 2026 02:59
e1078a4 to
2d57892
Compare
sergerad
requested review from
Keinberger,
Mirko-von-Leipzig and
kkovaacs
and removed request for
Keinberger
August 31, 2026 03:18
sergerad
force-pushed
the
sergerad-validator-admin-list
branch
from
September 2, 2026 01:17
2d57892 to
6ab831f
Compare
sergerad
force-pushed
the
sergerad-validator-admin-list
branch
3 times, most recently
from
September 2, 2026 03:27
43d0c4f to
fc3f127
Compare
The admin listing returned every stored record in one response, which
breaks on any non-trivial history. Replace it with a paginated listing
of committed transactions in committed order (block number, then index
within the block), served at /admin/v1/transactions. Pages are strict
keyset pages: (block_from, tx_index_from) is the cursor, the row limit
is honored exactly, and responses carry the PaginationInfo shape the
node's sync RPCs already use. Items are metadata-only unless
include_records is set, in which case each record is loaded by id.
Adds GET /admin/v1/transactions/{tx_id} to fetch one full record by id.
sergerad
force-pushed
the
sergerad-validator-admin-list
branch
from
September 2, 2026 03:43
fc3f127 to
ed3cc9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part 2 of a 4-PR stack formalizing the validator admin API (#2455).
The admin listing returned every stored record in one response, which OOMs/breaks on any non-trivial history. Replace it with a paginated listing of committed transactions in committed order, and version the admin paths under
/admin/v1/.GET /admin/v1/transactions?block_from=&tx_index_from=&block_to=&limit=&include_records=: rows ordered by(block_num, block_tx_index)— the only order with any bearing on the chain. In-flight / never-committed rows are not listed (they remain reachable by id).(block_from, tx_index_from)is the cursor, andlimitis honored exactly. Responses follow thePaginationInfoconvention of the node'ssync_*RPCs, carrying{ chain_tip, block_num, block_tx_index }; the next page is the same request resumed one position past the last row (block_from = block_num,tx_index_from = block_tx_index + 1). No opaque cursor.include_records=true, which loads each row's full sealed record by id under a lowerlimitcap — the full-record-per-row response was most of the memory problem.GET /admin/v1/transactions/{tx_id}returns one full record by id, including for uncommitted transactions.The listing query costs one indexed seek per page: the row-value comparison
(block_num, block_tx_index) >= (?, ?)seeks the link table's primary key directly (verified underEXPLAIN QUERY PLAN: no scan, no sort step).Stack: #2531 → #2532 → #2533 → #2517
Changelog