Enforce canonical tracing span attributes - #2510
Merged
Merged
Conversation
Mirko-von-Leipzig
force-pushed
the
mirko/tracing-spans
branch
2 times, most recently
from
August 24, 2026 11:45
53ebf42 to
23e592a
Compare
Mirko-von-Leipzig
force-pushed
the
mirko/tracing-spans
branch
from
August 24, 2026 12:22
23e592a to
ebb6a96
Compare
Mirko-von-Leipzig
force-pushed
the
mirko/tracing-spans
branch
from
August 24, 2026 15:20
ebb6a96 to
0c9be7b
Compare
Mirko-von-Leipzig
marked this pull request as ready for review
August 24, 2026 15:41
sergerad
reviewed
Aug 24, 2026
sergerad
reviewed
Aug 24, 2026
Mirko-von-Leipzig
force-pushed
the
mirko/tracing-spans
branch
from
August 27, 2026 13:34
0c9be7b to
cc91c3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tracing fields are now required to standardize on the
RecordAttributetrait. This PR applies this migration to the instrument and record fields macros. The macros no longer allow for?,%etc display style selections.In addition, this enables support for arbitrary
.countsuffixes which must be a usize field. This is intended to easily cover variousx.len()recording without being overly pedantic about the base name.Changelog