sftp: reply to a bad RMDIR path before logging it

RecvRMDIR answers a path GetAndCleanPath cannot resolve with FAILURE
straight away, as RecvMKDIR does, so the failure log never prints the
unfilled dir buffer.

- TestSftpFailedRequestsAnswered sends RMDIR an over-long path

Author: ejohnstown

src/wolfsftp.c

@@ -2229,6 +2229,11 @@ int wolfSSH_SFTP_RecvRMDIR(WOLFSSH* ssh, int reqId, byte* data, word32 maxSz)
     }
 
     ret = GetAndCleanPath(ssh, str, strSz, dir, sizeof(dir));
+    if (ret != WS_SUCCESS && ret != WS_PERMISSIONS) {
+        WLOG(WS_LOG_SFTP, "Unable to resolve directory path");
+        rc = SFTP_SendStatus(ssh, WOLFSSH_FTP_FAILURE, reqId, err);
+        return (rc == WS_SUCCESS) ? WS_BAD_FILE_E : rc;
+    }
 
     if (ret == 0) {
     #ifndef USE_WINDOWS_API

tests/regress.c

@@ -18514,8 +18514,8 @@ static void TestSftpFailedRequestsAnswered(void)
     char badFile[64];
     char badDir[64];
     const byte pathTypes[] = {
-        WOLFSSH_FTP_OPEN, WOLFSSH_FTP_MKDIR, WOLFSSH_FTP_REMOVE,
-        WOLFSSH_FTP_REALPATH,
+        WOLFSSH_FTP_OPEN, WOLFSSH_FTP_MKDIR, WOLFSSH_FTP_RMDIR,
+        WOLFSSH_FTP_REMOVE, WOLFSSH_FTP_REALPATH,
     #ifndef NO_WOLFSSH_DIR
         WOLFSSH_FTP_OPENDIR,
     #endif