Skip to content

Commit 3a67170

Browse files
committed
Fix v0.5.0 pentest findings
1 parent 46e2028 commit 3a67170

2 files changed

Lines changed: 19 additions & 0 deletions

File tree

‎crates/cardano-valkyoth-cbor/src/tests.rs‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,22 @@ fn tracker_fails_closed_on_input_byte_overflow() {
3737
assert_eq!(tracker.input_bytes(), 4);
3838
}
3939

40+
#[test]
41+
fn tracker_fails_closed_on_true_integer_overflow() {
42+
let budget = DecodeBudget::new(usize::MAX, 2, 3, 2, 5, 3);
43+
let mut tracker = DecodeBudgetTracker::new(budget);
44+
45+
assert_eq!(tracker.account_input_bytes(usize::MAX), Ok(()));
46+
assert_eq!(
47+
tracker.account_input_bytes(1),
48+
Err(DecodeBudgetError::InputTooLarge {
49+
max: usize::MAX,
50+
actual: usize::MAX
51+
})
52+
);
53+
assert_eq!(tracker.input_bytes(), usize::MAX);
54+
}
55+
4056
#[test]
4157
fn tracker_fails_closed_on_nesting_depth() {
4258
let mut tracker = DecodeBudgetTracker::new(BUDGET);

‎release-notes/RELEASE_NOTES_0.5.0.md‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@ Status: implementation stop reached; pentest required before tagging.
1616

1717
- Future untrusted parsers now have a shared explicit budget boundary before
1818
scalar, array, map, address, ledger, or script decoders are admitted.
19+
- Future recursive decoders must call `DecodeBudgetTracker::enter_nested()`
20+
and check its result before descending into nested arrays, maps, tags, or
21+
container values.
1922
- Budget errors preserve non-secret diagnostic counters for audit-log
2023
forensics.
2124
- No CBOR scalar parser, address parser, ledger validation, networking,

0 commit comments

Comments
 (0)