|
| 1 | +package control |
| 2 | + |
| 3 | +import ( |
| 4 | + "encoding/json" |
| 5 | + "testing" |
| 6 | + "time" |
| 7 | + |
| 8 | + "github.com/srcfl/ftw/go/internal/telemetry" |
| 9 | +) |
| 10 | + |
| 11 | +// The site meter's reads fail (held reading, no new UpdatedAt) while the |
| 12 | +// battery keeps reporting fresh telemetry. Within the 60 s watchdog window |
| 13 | +// dispatch must not act on the held meter value again and again. |
| 14 | +func runFrozenMeter(t *testing.T, heldGridW, realHouseW float64) (lastCmd, realGrid float64) { |
| 15 | + t.Helper() |
| 16 | + store := telemetry.NewStore() |
| 17 | + store.Update("meter", telemetry.DerMeter, heldGridW, nil, nil) |
| 18 | + store.DriverHealthMut("meter").RecordSuccess() |
| 19 | + soc := 0.5 |
| 20 | + store.Update("bat", telemetry.DerBattery, 0, &soc, nil) |
| 21 | + store.DriverHealthMut("bat").RecordSuccess() |
| 22 | + |
| 23 | + st := NewState(0, 50, "meter") |
| 24 | + st.Mode = ModeSelfConsumption |
| 25 | + clk := time.Now() |
| 26 | + st.clock = func() time.Time { return clk } |
| 27 | + capsMap := caps(map[string]float64{"bat": 10000}) |
| 28 | + st.DriverLimits = map[string]PowerLimits{"bat": {MaxChargeW: 10000, MaxDischargeW: 10000}} |
| 29 | + frozenAt := store.Get("meter", telemetry.DerMeter).UpdatedAt |
| 30 | + |
| 31 | + batW := 0.0 |
| 32 | + for tick := 0; tick < 10; tick++ { // 10 ticks x 5 s = 50 s < 60 s watchdog |
| 33 | + // Meter poll fails: RecordError, reading held. |
| 34 | + store.DriverHealthMut("meter").RecordError("modbus timeout") |
| 35 | + targets := ComputeDispatch(store, st, capsMap, 3*25*230) |
| 36 | + for _, tg := range targets { |
| 37 | + if tg.Driver == "bat" { |
| 38 | + batW = tg.TargetW |
| 39 | + } |
| 40 | + } |
| 41 | + // Battery follows its command and reports it (fresh). |
| 42 | + for i := 0; i < 30; i++ { |
| 43 | + store.Update("bat", telemetry.DerBattery, batW, &soc, nil) |
| 44 | + } |
| 45 | + store.DriverHealthMut("bat").RecordSuccess() |
| 46 | + t.Logf("tick %d: bat cmd %.0f W, real grid %.0f W, meter says %.0f W", |
| 47 | + tick, batW, realHouseW+batW, store.Get("meter", telemetry.DerMeter).SmoothedW) |
| 48 | + clk = clk.Add(5 * time.Second) |
| 49 | + } |
| 50 | + if !store.Get("meter", telemetry.DerMeter).UpdatedAt.Equal(frozenAt) { |
| 51 | + t.Fatal("meter reading moved") |
| 52 | + } |
| 53 | + return batW, realHouseW + batW |
| 54 | +} |
| 55 | + |
| 56 | +func TestFrozenImportMeterDoesNotDischargeToExport(t *testing.T) { |
| 57 | + cmd, grid := runFrozenMeter(t, 2000, 2000) |
| 58 | + if grid < -500 { |
| 59 | + t.Fatalf("frozen +2000 W meter drove battery to %.0f W; real grid %.0f W (export)", cmd, grid) |
| 60 | + } |
| 61 | +} |
| 62 | + |
| 63 | +func TestFrozenExportMeterDoesNotChargeFromGrid(t *testing.T) { |
| 64 | + cmd, grid := runFrozenMeter(t, -3000, 1500) |
| 65 | + if grid > 3000 { |
| 66 | + t.Fatalf("frozen -3000 W meter drove battery to %.0f W; real grid %.0f W (import)", cmd, grid) |
| 67 | + } |
| 68 | +} |
| 69 | + |
| 70 | +// A meter that stops updating after a good sample holds the battery at its |
| 71 | +// last order and lets a manual hold only cut toward 0. The next new sample |
| 72 | +// releases the hold. |
| 73 | +func TestHeldMeterOnlyCutsTowardZero(t *testing.T) { |
| 74 | + store := seedStore(2000, []struct { |
| 75 | + name string |
| 76 | + currentW, soc float64 |
| 77 | + }{{"bat", 0, 0.5}}) |
| 78 | + st := NewState(0, 50, "ferroamp") |
| 79 | + st.Mode = ModeSelfConsumption |
| 80 | + st.MinDispatchIntervalS = 0 |
| 81 | + st.SlewEnabled = false |
| 82 | + capsMap := caps(map[string]float64{"bat": 10000}) |
| 83 | + st.DriverLimits = map[string]PowerLimits{"bat": {MaxChargeW: 10000, MaxDischargeW: 10000}} |
| 84 | + |
| 85 | + first := targetFor(t, ComputeDispatch(store, st, capsMap, 3*25*230), "bat").TargetW |
| 86 | + if first >= 0 { |
| 87 | + t.Fatalf("fresh +2000 W import did not discharge: %.0f W", first) |
| 88 | + } |
| 89 | + store.Update("bat", telemetry.DerBattery, first, ptrF64(0.5), nil) |
| 90 | + if got := ComputeDispatch(store, st, capsMap, 3*25*230); len(got) != 0 { |
| 91 | + t.Fatalf("held meter sample produced new orders: %+v", got) |
| 92 | + } |
| 93 | + |
| 94 | + st.SetBatteryManualHold(BatteryManualHold{PowerW: first / 2, ExpiresAt: time.Now().Add(time.Hour)}) |
| 95 | + if got := targetFor(t, ComputeDispatch(store, st, capsMap, 3*25*230), "bat").TargetW; got != first/2 { |
| 96 | + t.Fatalf("cut toward 0 on a held sample: got %.0f W, want %.0f W", got, first/2) |
| 97 | + } |
| 98 | + st.SetBatteryManualHold(BatteryManualHold{PowerW: 3000, ExpiresAt: time.Now().Add(time.Hour)}) |
| 99 | + if got := targetFor(t, ComputeDispatch(store, st, capsMap, 3*25*230), "bat").TargetW; got != 0 { |
| 100 | + t.Fatalf("held sample allowed a reversal to charge: %.0f W", got) |
| 101 | + } |
| 102 | + |
| 103 | + store.Update("ferroamp", telemetry.DerMeter, 2000, nil, nil) |
| 104 | + if got := targetFor(t, ComputeDispatch(store, st, capsMap, 3*25*230), "bat").TargetW; got != 3000 { |
| 105 | + t.Fatalf("new sample did not release the hold: %.0f W", got) |
| 106 | + } |
| 107 | +} |
| 108 | + |
| 109 | +func heldMeterState() (*State, map[string]float64) { |
| 110 | + st := NewState(0, 50, "ferroamp") |
| 111 | + st.Mode = ModeSelfConsumption |
| 112 | + st.MinDispatchIntervalS = 0 |
| 113 | + st.SlewEnabled = false |
| 114 | + st.DriverLimits = map[string]PowerLimits{"bat": {MaxChargeW: 10000, MaxDischargeW: 10000}} |
| 115 | + return st, caps(map[string]float64{"bat": 10000}) |
| 116 | +} |
| 117 | + |
| 118 | +func reportBattery(store *telemetry.Store, w float64, data json.RawMessage) { |
| 119 | + soc := 0.5 |
| 120 | + for i := 0; i < 40; i++ { |
| 121 | + store.Update("bat", telemetry.DerBattery, w, &soc, data) |
| 122 | + } |
| 123 | + store.DriverHealthMut("bat").RecordSuccess() |
| 124 | +} |
| 125 | + |
| 126 | +func sentTo(targets []DispatchTarget, driver string) *DispatchTarget { |
| 127 | + for i := range targets { |
| 128 | + if targets[i].Driver == driver { |
| 129 | + return &targets[i] |
| 130 | + } |
| 131 | + } |
| 132 | + return nil |
| 133 | +} |
| 134 | + |
| 135 | +// A held meter must not keep a battery discharging after max_discharge_w |
| 136 | +// becomes an explicit 0. The deadband exit falls through for this; so must |
| 137 | +// the held exit. |
| 138 | +func TestHeldMeterStillSendsExplicitZeroDischarge(t *testing.T) { |
| 139 | + store := seedStore(2000, []struct { |
| 140 | + name string |
| 141 | + currentW, soc float64 |
| 142 | + }{{"bat", 0, 0.5}}) |
| 143 | + st, capsMap := heldMeterState() |
| 144 | + first := targetFor(t, ComputeDispatch(store, st, capsMap, 3*25*230), "bat").TargetW |
| 145 | + if first >= 0 { |
| 146 | + t.Fatalf("fresh +2000 W import did not discharge: %.0f W", first) |
| 147 | + } |
| 148 | + reportBattery(store, first, nil) |
| 149 | + st.DriverLimits = map[string]PowerLimits{"bat": {MaxChargeW: 10000, MaxDischargeW: 0, MaxDischargeWSet: true}} |
| 150 | + sent := sentTo(ComputeDispatch(store, st, capsMap, 3*25*230), "bat") |
| 151 | + if sent == nil || sent.TargetW < 0 { |
| 152 | + t.Fatalf("held meter left battery discharging at %.0f W under max_discharge_w=0: %+v", first, sent) |
| 153 | + } |
| 154 | +} |
| 155 | + |
| 156 | +// A held meter must not keep a battery charging after its driver reports |
| 157 | +// charge_capable=false. |
| 158 | +func TestHeldMeterStillStopsBlockedCharge(t *testing.T) { |
| 159 | + store := seedStore(-2000, []struct { |
| 160 | + name string |
| 161 | + currentW, soc float64 |
| 162 | + }{{"bat", 0, 0.5}}) |
| 163 | + st, capsMap := heldMeterState() |
| 164 | + first := targetFor(t, ComputeDispatch(store, st, capsMap, 3*25*230), "bat").TargetW |
| 165 | + if first <= 0 { |
| 166 | + t.Fatalf("fresh -2000 W export did not charge: %.0f W", first) |
| 167 | + } |
| 168 | + reportBattery(store, first, json.RawMessage(`{"charge_capable":false}`)) |
| 169 | + sent := sentTo(ComputeDispatch(store, st, capsMap, 3*25*230), "bat") |
| 170 | + if sent == nil || sent.TargetW > 0 { |
| 171 | + t.Fatalf("held meter left battery charging at %.0f W after charge_capable=false: %+v", first, sent) |
| 172 | + } |
| 173 | +} |
| 174 | + |
| 175 | +// A meter poll that emits and then returns an error leaves the latest read |
| 176 | +// marked failed on every tick, but each tick still brings a new sample. |
| 177 | +// Dispatch must act on it from a fresh start. |
| 178 | +func TestEmitThenErrorMeterIsNotHeld(t *testing.T) { |
| 179 | + store := seedStore(2000, []struct { |
| 180 | + name string |
| 181 | + currentW, soc float64 |
| 182 | + }{{"bat", 0, 0.5}}) |
| 183 | + st, capsMap := heldMeterState() |
| 184 | + acted := false |
| 185 | + for tick := 0; tick < 10; tick++ { |
| 186 | + time.Sleep(time.Millisecond) // UpdatedAt is wall-clock time |
| 187 | + store.Update("ferroamp", telemetry.DerMeter, 2000, nil, nil) |
| 188 | + store.DriverHealthMut("ferroamp").RecordSuccess() |
| 189 | + store.DriverHealthMut("ferroamp").RecordError("secondary register timeout") |
| 190 | + if sent := sentTo(ComputeDispatch(store, st, capsMap, 3*25*230), "bat"); sent != nil && sent.TargetW < 0 { |
| 191 | + acted = true |
| 192 | + } |
| 193 | + } |
| 194 | + if !acted { |
| 195 | + t.Fatal("ten new +2000 W meter samples, battery never dispatched") |
| 196 | + } |
| 197 | +} |
0 commit comments