|
| 1 | +package selfupdate |
| 2 | + |
| 3 | +import ( |
| 4 | + "context" |
| 5 | + "encoding/json" |
| 6 | + "fmt" |
| 7 | + "net/http" |
| 8 | + "net/http/httptest" |
| 9 | + "strconv" |
| 10 | + "sync/atomic" |
| 11 | + "testing" |
| 12 | +) |
| 13 | + |
| 14 | +// A stable may be promoted after newer betas ship, so GitHub lists it above |
| 15 | +// a higher beta. Beta boxes must still get the highest version. |
| 16 | +func TestCheck_BetaPrefersNewerBetaListedBelowPromotedStable(t *testing.T) { |
| 17 | + releases := fakeReleasesServer(t, nil, |
| 18 | + fakeRelease{tag: "v0.158.0"}, |
| 19 | + fakeRelease{tag: "v0.159.0-beta.1", prerelease: true}, |
| 20 | + fakeRelease{tag: "v0.158.0-beta.3", prerelease: true}, |
| 21 | + ) |
| 22 | + for _, tc := range []struct { |
| 23 | + current string |
| 24 | + update bool |
| 25 | + }{ |
| 26 | + {"v0.157.2-beta.1", true}, |
| 27 | + {"v0.158.0-beta.3", true}, |
| 28 | + {"v0.159.0-beta.1", false}, |
| 29 | + } { |
| 30 | + t.Run(tc.current, func(t *testing.T) { |
| 31 | + c := newCheckerOnFakes(t, tc.current, releases, newMemStore()) |
| 32 | + if err := c.SetChannel(ChannelBeta); err != nil { |
| 33 | + t.Fatalf("SetChannel: %v", err) |
| 34 | + } |
| 35 | + info, err := c.Check(context.Background(), true) |
| 36 | + if err != nil { |
| 37 | + t.Fatalf("Check: %v", err) |
| 38 | + } |
| 39 | + if info.Latest != "v0.159.0-beta.1" || info.UpdateAvailable != tc.update { |
| 40 | + t.Fatalf("latest=%q update=%v, want v0.159.0-beta.1 update=%v", info.Latest, info.UpdateAvailable, tc.update) |
| 41 | + } |
| 42 | + }) |
| 43 | + } |
| 44 | + |
| 45 | + stable := newCheckerOnFakes(t, "v0.157.2", releases, newMemStore()) |
| 46 | + info, err := stable.Check(context.Background(), true) |
| 47 | + if err != nil { |
| 48 | + t.Fatalf("stable Check: %v", err) |
| 49 | + } |
| 50 | + if info.Channel != ChannelStable || info.Latest != "v0.158.0" || !info.UpdateAvailable { |
| 51 | + t.Fatalf("stable info = %+v", info) |
| 52 | + } |
| 53 | +} |
| 54 | + |
| 55 | +// pagedReleasesServer serves one page per request and links each page to |
| 56 | +// the next, as GitHub does. |
| 57 | +func pagedReleasesServer(t *testing.T, calls *atomic.Int32, pages ...[]fakeRelease) *httptest.Server { |
| 58 | + t.Helper() |
| 59 | + var srv *httptest.Server |
| 60 | + srv = httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { |
| 61 | + calls.Add(1) |
| 62 | + page, _ := strconv.Atoi(r.URL.Query().Get("page")) |
| 63 | + if page+1 < len(pages) { |
| 64 | + w.Header().Set("Link", fmt.Sprintf(`<%s/releases?page=%d>; rel="next"`, srv.URL, page+1)) |
| 65 | + } |
| 66 | + list := make([]map[string]any, 0, len(pages[page])) |
| 67 | + for _, rel := range pages[page] { |
| 68 | + list = append(list, rel.json()) |
| 69 | + } |
| 70 | + _ = json.NewEncoder(w).Encode(list) |
| 71 | + })) |
| 72 | + t.Cleanup(srv.Close) |
| 73 | + return srv |
| 74 | +} |
| 75 | + |
| 76 | +func TestCheck_BetaWalksPastStableToTheFirstBetaAndStops(t *testing.T) { |
| 77 | + var calls atomic.Int32 |
| 78 | + releases := pagedReleasesServer(t, &calls, |
| 79 | + []fakeRelease{{tag: "v0.158.0"}}, |
| 80 | + []fakeRelease{{tag: "v0.159.0-beta.1", prerelease: true}}, |
| 81 | + []fakeRelease{{tag: "v0.157.0"}}, |
| 82 | + ) |
| 83 | + c := newCheckerOnFakes(t, "v0.158.0-beta.3", releases, newMemStore()) |
| 84 | + if err := c.SetChannel(ChannelBeta); err != nil { |
| 85 | + t.Fatalf("SetChannel: %v", err) |
| 86 | + } |
| 87 | + info, err := c.Check(context.Background(), true) |
| 88 | + if err != nil { |
| 89 | + t.Fatalf("Check: %v", err) |
| 90 | + } |
| 91 | + if info.Latest != "v0.159.0-beta.1" || !info.UpdateAvailable { |
| 92 | + t.Fatalf("beta info = %+v", info) |
| 93 | + } |
| 94 | + if got := calls.Load(); got != 2 { |
| 95 | + t.Fatalf("pages fetched = %d, want 2: the walk stops at the first beta", got) |
| 96 | + } |
| 97 | +} |
0 commit comments