From f8fe98e7d212fb5acaceeeace493f16b8a53168a Mon Sep 17 00:00:00 2001 From: Suraj Patil Date: Tue, 11 Aug 2026 00:30:31 +0530 Subject: [PATCH] [networkmanager] Declare NetworkManager in the services tuple setup() calls add_journal() for the NetworkManager unit but the plugin declares no services tuple and never collects the service status. An sosreport from a host with a networking problem therefore contains the journal but nothing showing whether the daemon is enabled, running, or failing to start. Plugin._collect_services() runs each entry of the tuple through is_service() and calls both add_service_status() and add_journal(), so declaring the unit adds the missing status and replaces the explicit call. It also gives the plugin an enablement trigger beyond the package name. The package differs between distributions - NetworkManager on Red Hat, network-manager on Debian and Ubuntu - while the unit is NetworkManager on both. Signed-off-by: Suraj Patil --- sos/report/plugins/networkmanager.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sos/report/plugins/networkmanager.py b/sos/report/plugins/networkmanager.py index 06b2b10eee..dc8f08f99d 100644 --- a/sos/report/plugins/networkmanager.py +++ b/sos/report/plugins/networkmanager.py @@ -16,6 +16,7 @@ class NetworkManager(Plugin, RedHatPlugin, UbuntuPlugin): plugin_name = 'networkmanager' profiles = ('network', 'hardware', 'system') packages = ('NetworkManager', 'network-manager') + services = ('NetworkManager',) def setup(self): self.system_connection_files = [ @@ -42,8 +43,6 @@ def setup(self): "/var/run/NetworkManager/secret_key" ) - self.add_journal(units="NetworkManager") - self.add_cmd_output("NetworkManager --print-config") # There are some incompatible changes in nmcli since