changes

Author: marcoacierno

backend/notifications/admin/admins.py

@@ -69,7 +69,7 @@ def get_readonly_fields(self, request: HttpRequest, obj: Any | None = None):
         fields = super().get_readonly_fields(request, obj)
 
         if obj:
-            fields = fields + ["conference", "is_system_template"]
+            fields = fields + ["conference", "is_system_template", "identifier"]
 
         return fields
 

backend/notifications/tests/admin/test_email_template_admin.py

@@ -50,6 +50,7 @@ def test_cannot_edit_essential_fields_on_existing_object(rf):
 
     assert "conference" in readonly_fields
     assert "is_system_template" in readonly_fields
+    assert "identifier" in readonly_fields
 
 
 def test_can_edit_essential_fields_on_new_objects(rf):

backend/schedule/models.py

@@ -1,6 +1,7 @@
 from dataclasses import dataclass
 from datetime import datetime, timedelta
 from typing import Optional
+from users.models import User
 from conferences.querysets import ConferenceQuerySetMixin
 
 from django.core import exceptions
@@ -335,8 +336,8 @@ def actual_attendees_total_capacity(self):
         return room.attendees_total_capacity if room else None
 
     @cached_property
-    def speakers(self):
-        speakers = []
+    def speakers(self) -> list[User]:
+        speakers = set()
 
         if self.submission_id:
             speakers.append(self.submission.speaker)
@@ -355,7 +356,7 @@ def speakers(self):
             speaker.user
             for speaker in sorted(additional_speakers, key=lambda speaker: speaker.id)
         )
-        return [speaker for speaker in speakers if speaker is not None]
+        return list([speaker for speaker in speakers if speaker is not None])
 
     def clean(self):
         if self.type == ScheduleItem.TYPES.submission and not self.submission:

backend/schedule/tasks.py

@@ -293,10 +293,9 @@ def upload_schedule_item_video(*, sent_for_video_upload_state_id: int):
     else:
         logger.info("Video already uploaded for schedule_item_id=%s", schedule_item.id)
 
-    if not sent_for_video_upload.thumbnail_uploaded:
-        video_id = video_id or schedule_item.youtube_video_id
-        assert video_id, "Video marked as uploaded but Video ID is missing"
+    assert video_id, "Video marked as uploaded but Video ID is missing"
 
+    if not sent_for_video_upload.thumbnail_uploaded:
         logger.info("Extracting thumbnail for schedule_item_id=%s", schedule_item.id)
 
         thumbnail_path = extract_video_thumbnail(