fix(CI): split documentation workflow to avoid pull_request_target checkout block - #12621
fix(CI): split documentation workflow to avoid pull_request_target checkout block#12621dlabaj wants to merge 6 commits into
Conversation
Removed an extra blank line in the README file.
* chore: fix hero props table (#12562) * fix: update tree pattern expand icon direction (#12554) * fix(tree-view): update expand icon direction * fix: update dls tree and tree table icons, too * chore: bump to latest core * chore: fix yarn.lock * chore(deps): Bump docs framework (#12583) Andrew reports that the wrong Felt class is being added to the html tag. I bumped the docs framework to one that has the correct class. * fix(Popover): fixed focus trapped on hoverable trigger (#12591) * fix(Popover): fixed focus trapped on hoverable trigger * Added deprecation to hoverable --------- Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com> Co-authored-by: Rebecca Alpert <ralpert@redhat.com> Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com>
Cherry-pick of the core bump from #12602 onto 6.6.x. Co-authored-by: Cursor <cursoragent@cursor.com>
- @patternfly/react-charts@8.6.1 - @patternfly/react-code-editor@6.6.1 - @patternfly/react-core@6.6.1 - @patternfly/react-docs@7.6.1 - @patternfly/react-drag-drop@6.6.1 - @patternfly/react-icons@6.6.1 - @patternfly/react-styles@6.6.1 - @patternfly/react-table@6.6.1 - @patternfly/react-templates@6.6.1 - @patternfly/react-tokens@6.6.1
…eckout block GitHub's actions/checkout@v4 now refuses to check out fork PR code from a pull_request_target workflow. Split the documentation workflow so PRs use the pull_request event (build + artifact upload) and a new workflow_run-triggered workflow handles the Surge deployment with secrets. Closes #12601 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Preview: https://pf-react-pr-12621.surge.sh A11y report: https://pf-react-pr-12621-a11y.surge.sh |
|
Closing: branch was created off 6.6.x instead of main, causing merge conflicts. Reopened as a clean PR from main with only the documentation workflow fix. |
Summary
pull_request_targettopull_requestso fork PRs no longer trigger the checkout security block fromactions/checkout@v4pull_requestevents, builds docs and a11y tests then uploads results as artifacts (no secrets needed)documentation-deploy.ymlworkflow triggered byworkflow_runthat downloads the artifacts and deploys to Surge using repo secretsissue_commentandworkflow_callpaths are unchanged — they still build and deploy directly since they have access to secretsCloses #12601
Test plan
issue_commentpath still works (re-trigger via bot comment)workflow_call) still builds and deploys docs🤖 Generated with Claude Code