Encountered an error with Return type of generator function

[RupeshMangalam21]

Hi everyone,
I’m working with the ocf-data-sampler repository and encountered an issue while running the tests. Specifically, I’m getting the following error:

Return type of generator function must be compatible with "Generator[Any, Any, Any]"
  "Generator[Any, Any, Any]" is not assignable to "Site"

This error occurs in the data_sites fixture in tests/conftest.py. The fixture is annotated to return a Site object, but it’s implemented as a generator function (using yield), which returns a Generator object instead.

I’m unsure whether the fixture should be refactored to return a Site object directly or if the return type annotation should be updated to Generator[Site, None, None].
Could you please clarify the intended behavior and suggest the best way to resolve this issue?

[AUdaltsova]

Hi @RupeshMangalam21! Is this related to the ruff work you are doing? If yes, I think it's fine to change it to a return, the Site object is just a config model so there shouldn't be any benefit from yielding it.

[RupeshMangalam21]

Hi @AUdaltsova , thank you for the response! yes i got this error while working with ruff changes, while running pytest. should i include the change you suggested in the same pr as the ruff one?