Completely false statement made wrt completely valid LKML patches

[brada4]

openwrt/openwrt#23123 (comment)

Patches are in rfc822/rfc2822 format exactly as git am expects.

[danielfdickinson]

Did you run make package/<package>/refresh on these? There is what I argue is a bug in the refresh logic that will add a space on any patch line which is only a newline (i.e. a 'context' line which is empty).

git diff-index --check ... complains about new trailing whitepace on the make refresh version of the patches.

[brada4]

git am does not complain.

[danielfdickinson]

I would not expect it to. The issue (as I see it) is a combination of a make refresh bug and the new CI enforcing that make refresh has been run. The latter would be fine if the former (the refresh whitespace bug) were not present.

I'm not arguing there is no issue; just pointing out what I think the root cause of the issue is.

[danielfdickinson]

Ok. I did make target/linux/refresh on https://github.com/LGA1150/openwrt/tree/fix-flowtable-roam and it is NOT the whitespace issue I was encountering. Sorry for the noise.

aside: The whitespace issue may be an editor auto-whitespace trimming issue, but that's a whole other topic.

[brada4]

@BKPepe @danielfdickinson please fix your attitude. Seriously. Valid lkml patch is talked down, then here heap if drive-by irrelevant, off-topic shit is posted in response. Also learn ñ habit to appologize to people slandered by you using scripts.