dead_code_analyzer:state: cleanup fields and constrs

Author: fantazio

src/state/opamStateTypes.mli

@@ -200,11 +200,6 @@ type +'lock switch_state = {
   reinstall: package_set Lazy.t;
   (** The set of packages which need to be reinstalled *)
 
-  invalidated: package_set Lazy.t;
-  (** The set of packages which are installed but no longer valid, e.g. because
-      of removed system dependencies. Only packages which are unavailable end up
-      in this set, they are otherwise put in {!field:reinstall}. *)
-
   overwrote_opams: (bool * OpamFile.OPAM.t) package_map;
   (** In case of simulated pins, keep the old information of opam files. The
       boolean is set to true if the package was previously pinned. *)

src/state/opamSwitchState.ml

@@ -637,12 +637,6 @@ let load lock_kind gt rt switch =
     (Lazy.force ext_files_changed %% Lazy.force available_packages) ++
     Lazy.force sys_packages_changed
   ) in
-  let invalidated = lazy (
-    Lazy.force changed ++
-    Lazy.force ext_files_changed ++
-    Lazy.force sys_packages_changed
-    -- Lazy.force available_packages
-  ) in
   let st = {
     switch_global = (gt :> unlocked global_state);
     switch_repos = (rt :> unlocked repos_state);
@@ -651,7 +645,7 @@ let load lock_kind gt rt switch =
     repos_package_index; installed_opams;
     installed; pinned; installed_roots;
     opams; conf_files;
-    packages; available_packages; sys_packages; reinstall; invalidated;
+    packages; available_packages; sys_packages; reinstall;
     overwrote_opams = OpamPackage.Map.empty;
   } in
   log "Switch state loaded in %.3fs" (chrono ());
@@ -696,7 +690,6 @@ let load_virtual ?repos_list ?(avail_default=true) gt rt =
     sys_packages = lazy OpamPackage.Map.empty;
     available_packages;
     reinstall = lazy OpamPackage.Set.empty;
-    invalidated = lazy (OpamPackage.Set.empty);
     overwrote_opams = OpamPackage.Map.empty;
   }