Skip to content

Fix/test datasets output - #4477

Merged
JulianFlesch merged 5 commits into
nf-core:devfrom
JulianFlesch:fix/test-datasets-output
Sep 22, 2026
Merged

JulianFlesch merged 5 commits into
nf-core:devfrom
JulianFlesch:fix/test-datasets-output

Conversation

@JulianFlesch

Copy link
Copy Markdown
Contributor
  • Fixes a bug in test-dataset with a broken import that was silent until the CLI speedup refactoring moved rich imports into top-level functions.
  • Adds test for test-datasets list
  • Catches an error if branch information cannot be fetched.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@JulianFlesch JulianFlesch self-assigned this Sep 21, 2026
@JulianFlesch
JulianFlesch marked this pull request as ready for review September 21, 2026 10:56
@codecov

codecov Bot commented Sep 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.39%. Comparing base (d91668e) to head (500141e).

Files with missing lines Patch % Lines
nf_core/test_datasets/test_datasets_utils.py 25.00% 3 Missing ⚠️
nf_core/test_datasets/list.py 80.00% 1 Missing ⚠️

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JulianFlesch
JulianFlesch merged commit df38c6d into nf-core:dev Sep 22, 2026
124 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants