fix(dav): detect added and removed birthday reminders

The trigger was only compared when both the existing and the new
birthday event had an alarm, so enabling or disabling the reminder
offset never updated existing events. Compare the triggers directly
and mention the reminder update in the repair step name.

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

Author: susnux

apps/dav/lib/CalDAV/BirthdayService.php

@@ -286,7 +286,7 @@ public function syncUser(string $user):void {
 	 * The birthday event is considered changed if either
 	 *  - the start date has changed
 	 *  - the title has changed
-	 *  - the time for the alarm has changed
+	 *  - the alarm was added, removed or its trigger has changed
 	 *
 	 * @param string $existingCalendarData
 	 * @param VCalendar $newCalendarData
@@ -303,7 +303,7 @@ public function birthdayEvenChanged(string $existingCalendarData,
 		return (
 			$newCalendarData->VEVENT->DTSTART->getValue() !== $existingBirthday->VEVENT->DTSTART->getValue()
 			|| $newCalendarData->VEVENT->SUMMARY->getValue() !== $existingBirthday->VEVENT->SUMMARY->getValue()
-			|| ($newCalendarData->VEVENT->VALARM && $existingBirthday->VEVENT->VALARM && $newCalendarData->VEVENT->VALARM->TRIGGER->getValue() !== $existingBirthday->VEVENT->VALARM->TRIGGER->getValue())
+			|| $newCalendarData->VEVENT->VALARM?->TRIGGER?->getValue() !== $existingBirthday->VEVENT->VALARM?->TRIGGER?->getValue()
 		);
 	}
 

apps/dav/lib/Migration/RegenerateBirthdayCalendars.php

@@ -32,7 +32,7 @@ public function __construct(
 	 */
 	#[\Override]
 	public function getName() {
-		return 'Regenerating birthday calendars to use new icons and fix old birthday events without year';
+		return 'Regenerating birthday calendars to use new icons, fix old birthday events without year and update reminders';
 	}
 
 	/**

apps/dav/tests/unit/CardDAV/BirthdayServiceTest.php

@@ -385,10 +385,19 @@ public static function providesBirthday(): array {
 				"BEGIN:VCALENDAR\r\nVERSION:2.0\r\nPRODID:-//Sabre//Sabre VObject 4.1.1//EN\r\nCALSCALE:GREGORIAN\r\nBEGIN:VEVENT\r\nUID:12345\r\nDTSTAMP:20160218T133704Z\r\nDTSTART;VALUE=DATE:19000101\r\nDTEND;VALUE=DATE:19000102\r\nRRULE:FREQ=YEARLY\r\nSUMMARY:12345's Birthday (1900)\r\nTRANSP:TRANSPARENT\r\nEND:VEVENT\r\nEND:VCALENDAR\r\n"],
 			[true,
 				"BEGIN:VCALENDAR\r\nVERSION:2.0\r\nPRODID:-//Sabre//Sabre VObject 4.1.1//EN\r\nCALSCALE:GREGORIAN\r\nBEGIN:VEVENT\r\nUID:12345\r\nDTSTAMP:20160218T133704Z\r\nDTSTART;VALUE=DATE:19000101\r\nDTEND;VALUE=DATE:19000102\r\nRRULE:FREQ=YEARLY\r\nSUMMARY:12345's Birthday (1900)\r\nTRANSP:TRANSPARENT\r\nEND:VEVENT\r\nEND:VCALENDAR\r\n",
-				"BEGIN:VCALENDAR\r\nVERSION:2.0\r\nPRODID:-//Sabre//Sabre VObject 4.1.1//EN\r\nCALSCALE:GREGORIAN\r\nBEGIN:VEVENT\r\nUID:12345\r\nDTSTAMP:20160218T133704Z\r\nDTSTART;VALUE=DATE:19000102\r\nDTEND;VALUE=DATE:19000102\r\nRRULE:FREQ=YEARLY\r\nSUMMARY:12345's Birthday (1900)\r\nTRANSP:TRANSPARENT\r\nEND:VEVENT\r\nEND:VCALENDAR\r\n"]
+				"BEGIN:VCALENDAR\r\nVERSION:2.0\r\nPRODID:-//Sabre//Sabre VObject 4.1.1//EN\r\nCALSCALE:GREGORIAN\r\nBEGIN:VEVENT\r\nUID:12345\r\nDTSTAMP:20160218T133704Z\r\nDTSTART;VALUE=DATE:19000102\r\nDTEND;VALUE=DATE:19000102\r\nRRULE:FREQ=YEARLY\r\nSUMMARY:12345's Birthday (1900)\r\nTRANSP:TRANSPARENT\r\nEND:VEVENT\r\nEND:VCALENDAR\r\n"],
+			'same reminder' => [false, self::birthdayWithReminder('PT9H'), self::birthdayWithReminder('PT9H')],
+			'changed reminder' => [true, self::birthdayWithReminder('-PT0M'), self::birthdayWithReminder('PT9H')],
+			'added reminder' => [true, self::birthdayWithReminder(null), self::birthdayWithReminder('PT9H')],
+			'removed reminder' => [true, self::birthdayWithReminder('-PT0M'), self::birthdayWithReminder(null)],
 		];
 	}
 
+	private static function birthdayWithReminder(?string $trigger): string {
+		$alarm = $trigger === null ? '' : "BEGIN:VALARM\r\nTRIGGER;VALUE=DURATION:$trigger\r\nACTION:DISPLAY\r\nDESCRIPTION:12345's Birthday (1900)\r\nEND:VALARM\r\n";
+		return "BEGIN:VCALENDAR\r\nVERSION:2.0\r\nPRODID:-//Sabre//Sabre VObject 4.1.1//EN\r\nCALSCALE:GREGORIAN\r\nBEGIN:VEVENT\r\nUID:12345\r\nDTSTAMP:20160218T133704Z\r\nDTSTART;VALUE=DATE:19000101\r\nDTEND;VALUE=DATE:19000102\r\nRRULE:FREQ=YEARLY\r\nSUMMARY:12345's Birthday (1900)\r\nTRANSP:TRANSPARENT\r\n{$alarm}END:VEVENT\r\nEND:VCALENDAR\r\n";
+	}
+
 	public static function providesCardChanges(): array {
 		return[
 			['delete'],

apps/dav/tests/unit/Migration/RegenerateBirthdayCalendarsTest.php

@@ -33,7 +33,7 @@ protected function setUp(): void {
 
 	public function testGetName(): void {
 		$this->assertEquals(
-			'Regenerating birthday calendars to use new icons and fix old birthday events without year',
+			'Regenerating birthday calendars to use new icons, fix old birthday events without year and update reminders',
 			$this->migration->getName()
 		);
 	}