fix(files): consider all shares of the target when moving mount points

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Ghassen kefi <ghassen.kefi.dev@gmail.com>

Author: GhassenKefi

lib/private/Files/View.php

@@ -1893,32 +1893,29 @@ private function targetIsNotShared(string $user, string $targetPath): bool {
 		$providers = [
 			IShare::TYPE_USER,
 			IShare::TYPE_GROUP,
+			IShare::TYPE_LINK,
 			IShare::TYPE_EMAIL,
 			IShare::TYPE_CIRCLE,
 			IShare::TYPE_ROOM,
 			IShare::TYPE_DECK,
 		];
 		$shareManager = Server::get(IManager::class);
-		/** @var IShare[] $shares */
-		$shares = array_merge(...array_map(function (int $type) use ($shareManager, $user) {
-			return $shareManager->getSharesBy($user, $type);
-		}, $providers));
+		$rootFolder = Server::get(IRootFolder::class);
+		$userFolderPath = '/' . $user . '/files';
 
-		foreach ($shares as $share) {
+		for ($path = $targetPath; str_starts_with($path, $userFolderPath . '/'); $path = dirname($path)) {
 			try {
-				$sharedPath = $share->getNode()->getPath();
-			} catch (NotFoundException $e) {
-				// node is not found, ignoring
-				$this->logger->debug(
-					'Could not find the node linked to a share',
-					['app' => 'files', 'exception' => $e]);
+				$node = $rootFolder->get($path);
+			} catch (NotFoundException) {
 				continue;
 			}
-			if ($targetPath === $sharedPath || str_starts_with($targetPath, $sharedPath . '/')) {
-				$this->logger->debug(
-					'It is not allowed to move one mount point into a shared folder',
-					['app' => 'files']);
-				return false;
+			foreach ($providers as $type) {
+				if ($shareManager->getSharesBy($user, $type, $node, false, 1) !== []) {
+					$this->logger->debug(
+						'It is not allowed to move one mount point into a shared folder',
+						['app' => 'files']);
+					return false;
+				}
 			}
 		}
 

tests/lib/Files/ViewTest.php

@@ -32,6 +32,7 @@
 use OCP\Files\InvalidPathException;
 use OCP\Files\IRootFolder;
 use OCP\Files\Mount\IMountManager;
+use OCP\Files\Node;
 use OCP\Files\NotFoundException;
 use OCP\Files\Storage\IStorage;
 use OCP\Files\Storage\IStorageFactory;
@@ -1782,6 +1783,46 @@ public function testMoveMountPointIntoSharedFolder(): void {
 		$userObject->delete();
 	}
 
+	public function testMoveMountPointIntoLinkSharedFolder(): void {
+		self::loginAsUser(self::$user);
+
+		[$mount1] = $this->createTestMovableMountPoints([
+			self::$user . '/files/mount1',
+		]);
+		$mount1->expects($this->never())
+			->method('moveMount');
+
+		$view = new View('/' . self::$user . '/files/');
+		$userFolder = Server::get(IRootFolder::class)->getUserFolder(self::$user);
+		$shareManager = Server::get(IShareManager::class);
+		$shares = [];
+		// More links than a single page of shares, created before the shared target
+		for ($i = 0; $i <= 50; $i++) {
+			$view->mkdir('other' . $i);
+			$shares[] = $this->createLinkShare($shareManager, $userFolder->get('other' . $i));
+		}
+		$view->mkdir('linkdir');
+		$shares[] = $this->createLinkShare($shareManager, $userFolder->get('linkdir'));
+
+		try {
+			$this->expectException(ForbiddenException::class);
+			$view->rename('mount1', 'linkdir/mount1');
+		} finally {
+			foreach ($shares as $share) {
+				$shareManager->deleteShare($share);
+			}
+		}
+	}
+
+	private function createLinkShare(IShareManager $shareManager, Node $node): IShare {
+		$share = $shareManager->newShare();
+		$share->setSharedBy(self::$user)
+			->setShareType(IShare::TYPE_LINK)
+			->setPermissions(Constants::PERMISSION_READ)
+			->setNode($node);
+		return $shareManager->createShare($share);
+	}
+
 	public static function basicOperationProviderForLocks(): array {
 		return [
 			// --- write hook ----