Repository navigation
Replies: 1 comment 1 reply
|
Transfering this one to the operator repo so it's easier to track 🙌 |
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Hi NetBird folks,
We have been testing the new Kubernetes API server proxy flow from:
The proxy itself looks good so far. The operator reconciles the
ClusterProxy, the proxy peers join the expected NetBird group, and a manual kubeconfig pointed at:can reach the Kubernetes API through NetBird.
The problem is that
netbird kubernetes listfails before it can list the cluster if any peer in the network map has no reverse DNS record.Example from Linux with NetBird CLI/daemon
0.73.2:Example from Windows with NetBird CLI/daemon
0.73.2:That Windows peer otherwise looked healthy:
I think the failure is here:
https://github.com/netbirdio/netbird/blob/main/client/cmd/kubernetes.go
Current behavior in
getKubernetesClusters:So one ordinary peer without a PTR record aborts the whole Kubernetes discovery command. In our setup, the actual Kubernetes proxy peers do have the expected extra DNS label:
but the CLI never gets that far because it returns on an unrelated peer's PTR lookup failure.
Expected behavior:
netbird kubernetes listshould still list reachable Kubernetes proxy peersnetbird kubernetes write-kubeconfig <cluster>should not require every unrelated peer in the network map to have reverse DNSOur local workaround is to create the kubeconfig manually with the proxy FQDN:
That is fine for testing, but it is not something we can reasonably ask every developer to do.
Would you be open to a small PR that makes PTR lookup failures non-fatal in Kubernetes discovery, plus a regression test?
All reactions