From 82e23538692fe069f194ec51335789bc04f44f39 Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Mon, 7 Sep 2026 16:02:02 -0700 Subject: [PATCH 1/2] style: bump clang-format to v19 --- .github/workflows/cpp_lint.yaml | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/workflows/cpp_lint.yaml b/.github/workflows/cpp_lint.yaml index ff90c26..326d503 100644 --- a/.github/workflows/cpp_lint.yaml +++ b/.github/workflows/cpp_lint.yaml @@ -16,6 +16,8 @@ permissions: {} jobs: cpp_linter: + env: + CLANG_FORMAT_VERSION: 19 runs-on: ubuntu-latest permissions: # allow cpp-linter to post suggestions in PR reviews @@ -30,7 +32,7 @@ jobs: with: python-version: 3.x - name: Install clang-format - run: sudo apt-get install clang-format-14 + run: sudo apt-get install -y clang-format-${CLANG_FORMAT_VERSION} - name: Install linter python package run: python3 -m pip install 'cpp-linter>=1.7.1' - name: Run cpp-linter (python package) @@ -41,7 +43,7 @@ jobs: EXTENSIONS: ${{ inputs.extensions }} run: >- cpp-linter - --version=14 + --version=${CLANG_FORMAT_VERSION} --style=file --tidy-checks='-*' --lines-changed-only=true @@ -52,4 +54,6 @@ jobs: --step-summary=true - name: Linter checks failed? if: steps.linter.outputs.checks-failed > 0 - run: exit 1 + run: |- + echo "format checks failed: ${{ steps.linter.outputs.checks-failed }}" + exit 1 From 83433bbeffe940b45eb2bb28e29a305914da5d9f Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Mon, 7 Sep 2026 16:05:01 -0700 Subject: [PATCH 2/2] please zizmor lint --- .github/workflows/cpp_lint.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/cpp_lint.yaml b/.github/workflows/cpp_lint.yaml index 326d503..2eb9de4 100644 --- a/.github/workflows/cpp_lint.yaml +++ b/.github/workflows/cpp_lint.yaml @@ -54,6 +54,8 @@ jobs: --step-summary=true - name: Linter checks failed? if: steps.linter.outputs.checks-failed > 0 + env: + CHECKS_FAILED: ${{ steps.linter.outputs.checks-failed }} run: |- - echo "format checks failed: ${{ steps.linter.outputs.checks-failed }}" + echo "format checks failed: ${CHECKS_FAILED}" exit 1