Repository navigation
Move pnpm from 8.13.1 to 11.28.6 - #287
Merged
Merged
Conversation
The root .prettierrc.js loads prettier-plugin-solidity, which only solidity/ depends on. pnpm 8 hoists every package with eslint or prettier in its name to the root node_modules, so the dapp's eslint run finds the plugin there. pnpm 10 dropped that default, and the dapp format check fails with "Cannot find package 'prettier-plugin-solidity'". This sets pnpm 8's default explicitly. pnpm 8 doesn't read the setting from pnpm-workspace.yaml, so nothing changes until the pnpm bump.
pnpm 10 stopped running dependency build scripts by default, and pnpm 11 fails the install when a dependency with a build script isn't listed in allowBuilds. pnpm 11 reports esbuild, keccak and secp256k1 for this lockfile. The values match web's allowBuilds for the same packages. pnpm 8 ignores the setting, so this changes nothing until the pnpm bump.
pnpm 8.13.1 is inside the range of several high-severity pnpm advisories from 2026, for example a file write outside node_modules on install, and secrets read through proxy settings in an untrusted pnpm-workspace.yaml. The 8.x line has no fixed release. 11.28.6 is npm's latest-11, the line web uses. The lockfile moves from format 6.0 to 9.0. pnpm 11 can't read 6.0 and resolves every dependency again, so the lockfile was converted with pnpm 9.15.9 first and then rewritten by pnpm 11. Every resolved version stays the same. Only the git-hosted @thesis/prettier-config entry changes its key format, and it still points at commit daeaac5. solidity/ also declares packageManager. Inside the workspace pnpm reads the root one, but both move together so they don't disagree.
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 100% | 2/2 |
| 🟢 | Branches | 100% | 0/0 |
| 🟢 | Functions | 100% | 1/1 |
| 🟢 | Lines | 100% | 2/2 |
Test suite run success
2 tests passing in 1 suite.
Report generated by 🧪jest coverage report action from be42419
nkuba
marked this pull request as ready for review
October 22, 2026 20:20
lukasz-zimnoch
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpm 8.13.1 is inside the range of several high-severity pnpm advisories from 2026. The 8.x line has no fixed release, so this moves to 11.28.6, npm's
latest-11and the line web uses.pnpm 11 can't read the 6.0 lockfile and would resolve every dependency again. The lockfile was converted with pnpm 9.15.9 first, so every resolved version stays the same. The big lockfile diff is the format change.
Two pnpm 10 defaults needed settings in
pnpm-workspace.yaml:allowBuildslists esbuild, keccak and secp256k1, with web's values.prettier-plugin-solidityfrom the root.prettierrc.js.publicHoistPatternkeeps pnpm 8's default.Locally on Node 26.12.1 with pnpm 11.28.6,
pnpm install --frozen-lockfile, the solidity build, format and tests, and the dapp format, test and build pass.test:upgradesneedsMEZO_RPC_URL, so it only runs in CI.Resolves: https://linear.app/thesis-co/issue/MEZO-5260