Add feature to directly use the OS-provided RNG instead of rand - #403
Closed
MatMaul wants to merge 1 commit into
Closed
Add feature to directly use the OS-provided RNG instead of rand#403MatMaul wants to merge 1 commit into
rand#403MatMaul wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #403 +/- ##
=======================================
Coverage 91.72% 91.72%
=======================================
Files 40 40
Lines 5533 5536 +3
Branches 5533 5536 +3
=======================================
+ Hits 5075 5078 +3
Misses 287 287
Partials 171 171 ☔ View full report in Codecov by Harness. |
Collaborator
|
Isn't this more generally solved by #379? |
Contributor
Author
|
Indeed thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The os-rng feature enables the use of the operating system's RNG instead of the default random number generator provided by the
randcrate, which is not backtracking resistant.This is usually not necessary, but can be enabled for security-critical applications or compliance purposes.
Please note that OS RNG is not guaranteed to be backtracking resistant either since it will depend on the underlying OS implementation, but the RNG state will be available in kernel space instead of user space so harder to extract.