ci: use FIPS image variants in langsmith readonly test - #692
Open
Mukil Loganathan (langchain-infra) wants to merge 2 commits into
Open
ci: use FIPS image variants in langsmith readonly test#692Mukil Loganathan (langchain-infra) wants to merge 2 commits into
Mukil Loganathan (langchain-infra) wants to merge 2 commits into
Conversation
Mukil Loganathan (langchain-infra)
requested a review
from a team
as a code owner
April 24, 2026 16:55
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
charts/langsmith/ci/readonly-config-values.yamlto their-fipscounterparts so the readonly CI job exercises FIPS images alongside thereadOnlyRootFilesystem: trueconfiguration.repositoryis overridden —tagandpullPolicycontinue to flow from the chart's defaultvalues.yaml, so each release automatically pulls the matching FIPS build.Test plan
helm lint charts/langsmith -f charts/langsmith/ci/readonly-config-values.yamlhelm template charts/langsmith -f charts/langsmith/ci/readonly-config-values.yamlshows the 7 overridden repositories and default tag