Skip to content

file_suffix is not extracted properly #102

Description

@michaelcroquette

Hello,

We would like to add a specific string at the end the h5 file when saving data. The seems to be a file_suffix parameter:

def save_acquisition(
        self, update_: bool = True, /, file_suffix: Optional[str] = None, **kwds
    ) -> "AcquisitionAnalysisManager":
        acquisition_finished = time.time()
        if not self._once_saved:
            additional_info: Dict[str, Any] = {
                "acquisition_duration": acquisition_finished - self._acquisition_started,
                "logs": self.logger.getvalue(),
                "prints": self.logger.get_stdout(),
            }
            if self._default_config_files:
                additional_info.update({"default_config_files": self._default_config_files})
            kwds.update({"info": additional_info})

        super().save_acquisition(update_, file_suffix=file_suffix, **kwds)
        self._load_analysis_data()
        return self

But in AcquisitionManager.save_acquisition it is not used:

def save_acquisition(self, update_: bool = True, /, **kwds) -> "AcquisitionManager":

Is this the intended purpose of this suffix ?

It can be a pain to identify a specific curve in a folder when the only differences are the date tag at the beginning of the filename.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingfeatureNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions