[WIP] Pandora interface for the IDEA detector - #52
Draft
SanghyunKo wants to merge 63 commits into
Draft
Conversation
Co-authored-by: Thomas Madlener <thomas.madlener@desy.de>
Co-authored-by: Juan Miguel Carceller <22276694+jmcarcell@users.noreply.github.com>
Co-authored-by: Juan Miguel Carceller <22276694+jmcarcell@users.noreply.github.com>
Co-authored-by: Juan Miguel Carceller <22276694+jmcarcell@users.noreply.github.com>
Co-authored-by: Juan Miguel Carceller <22276694+jmcarcell@users.noreply.github.com>
Co-authored-by: Juan Miguel Carceller <22276694+jmcarcell@users.noreply.github.com>
Co-authored-by: Thomas Madlener <thomas.madlener@desy.de>
Co-authored-by: Juan Miguel Carceller <22276694+jmcarcell@users.noreply.github.com>
Co-authored-by: Juan Miguel Carceller <22276694+jmcarcell@users.noreply.github.com>
Co-authored-by: Juan Miguel Carceller <22276694+jmcarcell@users.noreply.github.com>
Co-authored-by: Juan Miguel Carceller <22276694+jmcarcell@users.noreply.github.com>
…emove obsolte algos, 4) file name change
# Conflicts: # k4GaudiPandora/options/runExternalClustering.py # test/CMakeLists.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES
Add Pandora interface for the IDEA detector. IDEA has some major differences (especially for calo hits) compared to the CLD/ILD detectors, forcing us to create a dedicated interface rather than reusing unless there comes a significant refactoring. I tried to share components (e.g. track interface) as much as possible though.
This PR already contains #26 (I developed on top of it). Should be rebased after #26 is merged.
Requires:
(This PR is the most downstream one)
A lot of PRs must be precedented in advance of this PR. Nevertheless I take advantage of creating the PR as draft because there might be some strategical comments which would require some work. We can take care of tactical/minor comments in the later stage.