[wangben718]

Pull Request

The validation message spans become block elements with a CSS rule on teal's own .shiny-input-validation-error class, so each message gets its own line.

Fixes #1717

[github-actions]

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  -----------------------------------------------------------------------------------------------------
R/after.R                            59      21  64.41%   42-52, 64, 69, 77-79, 81-89, 100, 104-105
R/checkmate.R                        24       0  100.00%
R/decorators-helpers.R               59       1  98.31%   113
R/dummy_functions.R                  61       2  96.72%   54, 56
R/include_css_js.R                   11       0  100.00%
R/init.R                            136       0  100.00%
R/module_bookmark_manager.R          99      54  45.45%   78-133
R/module_data_summary.R             177       8  95.48%   40, 50, 205, 236-240
R/module_filter_data.R               64       0  100.00%
R/module_filter_manager.R           210       7  96.67%   119-120, 316, 343, 355, 362-363
R/module_nested_tabs.R              411      42  89.78%   120, 178-183, 211, 315-330, 350-354, 409, 527-530, 534-537, 541-544
R/module_session_info.R              18       0  100.00%
R/module_snapshot_manager.R         276       9  96.74%   315-319, 386, 389-391
R/module_source_code.R               69       0  100.00%
R/module_teal_lockfile.R            131      53  59.54%   45-57, 60-62, 76, 86-88, 100-102, 110-119, 122, 124, 126-127, 142-146, 161-162, 177-186
R/module_teal_reporter.R            122       9  92.62%   60, 77-78, 81, 98, 128, 142, 144, 158
R/module_teal.R                     310      26  91.61%   137, 186, 242, 272-292, 322-323
R/module_transform_data.R           164      25  84.76%   77-81, 85-89, 106, 112, 119-120, 134-138, 188, 273-277
R/module_validate_error.R            73       0  100.00%
R/modules.R                         345      50  85.51%   170-174, 229-232, 332, 339, 353, 472, 570-576, 706-712, 725-733, 748-763, 796, 808-816
R/reporter_previewer_module.R        41      12  70.73%   41, 45, 68-85
R/teal_data_module-eval_code.R       23       0  100.00%
R/teal_data_module-within.R           7       0  100.00%
R/teal_data_module.R                 23       0  100.00%
R/teal_data_utils.R                  49       0  100.00%
R/teal_modifiers.R                   57       0  100.00%
R/teal_slices-store.R                29       0  100.00%
R/teal_slices.R                      48       2  95.83%   153-154
R/teal_transform_module.R            45       0  100.00%
R/TealAppDriver.R                   353     244  30.88%   68-73, 126, 134-163, 194-203, 213, 228-276, 301-564, 592-617, 672, 674-677, 696-710, 727-728, 739-756
R/utils.R                           290      48  83.45%   404-453, 541-550
R/validate_inputs.R                  60       0  100.00%
R/validations.R                      58       0  100.00%
R/zzz.R                              21       0  100.00%
TOTAL                              3923     613  84.37%

Diff against main

Filename               Stmts    Miss  Cover
-------------------  -------  ------  --------
R/validate_inputs.R       +3       0  +100.00%
TOTAL                     +3       0  +0.01%

Results for commit: b292fc4

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[github-actions]

Unit Tests Summary

  1 files   36 suites   2m 51s ⏱️
487 tests 417 ✅ 70 💤 0 ❌
754 runs  684 ✅ 70 💤 0 ❌

Results for commit b292fc4.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
module_session_info	💔	$18.85$	$+3.52$	$0$	$0$	$0$	$0$
module_teal	💔	$126.59$	$+4.76$	$0$	$0$	$0$	$0$
teal_modifiers	💔	$3.98$	$+1.78$	$0$	$0$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
module_session_info	💔	$18.83$	$+3.52$	srv_session_info_lockfile_creation_process_is_invoked_for_teal.lockfile.mode_enabled_and_snapshot_is_copied_to_teal_app.lock_and_removed_after_session_ended
teal_modifiers	💔	$0.07$	$+1.01$	function_chaining_all_modifiers_can_be_chained_together

Results for commit 4568a69

♻️ This comment has been updated with latest results.

[llrs-roche]

Nice PR, simple and elegant.

I verified that the modified test on main fails. Just two comments regarding some changes

[llrs-roche]

Let's merge. I tested locally without the hash of the message and saw a number of tests failing and with the current changes they pass 👍