Add font_size to annotate_lineplot_df() (#296)

**What changes are proposed in this pull request?**
* `annotate_lineplot_df()` gains a `font_size` argument to control the
summary table font size, and `annotate_pkc_df()` now applies its
`text_size` argument. (#295)

`annotate_lineplot_df()` had no way to set the summary table font size,
so it was fixed at the `df2gg_aligned()` defaults. `font_size` maps to
`text_size`/`label_size`, matching `annotate_riskdf()`.
`annotate_pkc_df()` already declared `text_size` but never forwarded it.

**Reference GitHub issue associated with pull request.** closes #295


--------------------------------------------------------------------------------

Pre-review Checklist (if item does not apply, mark is as complete)
- [x] **All** GitHub Action workflows pass with a ✅
- [x] PR branch has pulled the most recent updates from master branch:
`usethis::pr_merge_main()`
- [x] If a bug was fixed, a unit test was added.
- [x] Code coverage is suitable for any new functions/features
(generally, 100% coverage for new code): `devtools::test_coverage()`
- [ ] Request a reviewer

---------

Signed-off-by: Davide Garolini <dgarolini@gmail.com>

Author: Melkiades

NEWS.md

@@ -2,6 +2,8 @@
 
 * Added `modify_split_caption()` to subtitle each page of a split `{gtsummary}` table (e.g. from `tbl_listing()`, `tbl_baseline_chg()`, or `tbl_shift()`) from its split level via a glue `pattern` (default `"Parameter: {spl_level}"`) and hide the now-redundant split column. (#282)
 
+* `annotate_lineplot_df()` and `annotate_pkc_df()` gain a `font_size` argument to control the summary table font size, matching `annotate_riskdf()`. The `text_size` argument of `annotate_pkc_df()` is soft-deprecated in favor of `font_size`. (#295)
+
 * Renamed `imputation_rules()` to `pk_imputation_rules()` to make its PK scope explicit. It applies BLQ display rules to PK summary statistics based on the BLQ ratio and dosing timing, and now marks any missing statistic (e.g. standard deviation or CV% when `n = 1`) as `"NE"` (not estimable). (#293)
 
 * Renamed `d_pkparam()` to `pk_param_metadata()` and `h_pkparam_sort()` to `pk_param_sort()`, dropping the `d_`/`h_` prefixes. `pk_param_sort()` now warns about parameter codes missing from the reference and keeps their rows instead of dropping them silently. (#293)

R/annotate_gg.R

@@ -19,6 +19,8 @@
 #'   Can be a single integer (e.g., `2`), a vector of integers matching the statistics
 #'   (e.g., `c(0, 2, 2)`), or a `gtsummary` style formula. Defaults to `NULL`
 #'   (uses `gtsummary` default auto-formatting).
+#' @param font_size (`numeric`)\cr
+#'   Base font size for the summary table text. Defaults to `10`.
 #' @param rel_height_plot (`numeric`)\cr
 #'   Relative height of the plot vs the table. Defaults to `0.75`.
 #'
@@ -62,6 +64,7 @@ annotate_lineplot_df <- function(gg_plt,
                                  group = NULL,
                                  summary_stats = c("n", "mean", "sd"),
                                  digits = NULL,
+                                 font_size = 10,
                                  rel_height_plot = 0.75) {
   if (!inherits(gg_plt, "crane_gg_line")) {
     cli::cli_warn(c(
@@ -164,6 +167,8 @@ annotate_lineplot_df <- function(gg_plt,
     show_xaxis = FALSE,
     type = "GEN",
     y_labels = y_labels,
+    text_size = font_size / ggplot2::.pt,
+    label_size = font_size,
     rel_height_plot = rel_height_plot
   )
 }

R/annotate_gg_pkc.R

@@ -19,8 +19,10 @@
 #'   Can be a single integer (e.g., `2`), a vector of integers matching the statistics
 #'   (e.g., `c(0, 2, 2)`), or a `gtsummary` style formula. Defaults to `NULL`
 #'   (uses `gtsummary` default auto-formatting).
-#' @param text_size (`numeric`)\cr
-#'   The font size for the table text. Defaults to `3.5`.
+#' @param font_size (`numeric`)\cr
+#'   Base font size for the summary table text. Defaults to `10`.
+#' @param text_size `r lifecycle::badge("deprecated")`\cr
+#'   Use `font_size` instead.
 #' @param rel_height_plot (`numeric`)\cr
 #'   Relative height of the plot vs the table. Defaults to `0.75`.
 #' @returns A ggplot2 object: a plot with a table at the bottom.
@@ -61,6 +63,13 @@
 #'   summary_stats = c("n", "median", "iqr"),
 #'   digits = c(0, 2, 2)
 #' )
+#'
+#' # Annotate with a larger summary table font
+#' annotate_pkc_df(
+#'   data = df_pk,
+#'   gg_plt = p_pk,
+#'   font_size = 12
+#' )
 #' @export
 annotate_pkc_df <- function(gg_plt,
                             data,
@@ -69,8 +78,18 @@ annotate_pkc_df <- function(gg_plt,
                             group = NULL,
                             summary_stats = c("n", "mean", "sd"),
                             digits = NULL,
-                            text_size = 3.5,
+                            font_size = 10,
+                            text_size = lifecycle::deprecated(),
                             rel_height_plot = 0.75) {
+  if (lifecycle::is_present(text_size)) {
+    lifecycle::deprecate_soft(
+      "0.3.4",
+      "crane::annotate_pkc_df(text_size)",
+      "crane::annotate_pkc_df(font_size)"
+    )
+    font_size <- text_size * ggplot2::.pt
+  }
+
   # 1. Input Validation---------------------------------------------------------
   if (!inherits(gg_plt, "crane_gg_pkc")) {
     cli::cli_warn(c(
@@ -181,6 +200,7 @@ annotate_pkc_df <- function(gg_plt,
     show_xaxis = FALSE,
     type = "PK",
     y_labels = pk_y_labels,
+    text_size = font_size / ggplot2::.pt,
     rel_height_plot = rel_height_plot
   )
 

man/annotate_lineplot_df.Rd

@@ -135,3 +135,21 @@ test_that("annotate_lineplot_df formats numeric digits correctly", {
   # Check 'sd' has a decimal point followed by EXACTLY 2 digits (e.g., "0.71")
   expect_true(grepl("\\.[0-9]{2}$", val_sd))
 })
+
+test_that("annotate_lineplot_df forwards font_size to df2gg_aligned", {
+  captured <- NULL
+  mock_df2gg <- function(df, ..., text_size, label_size) {
+    captured <<- list(text_size = text_size, label_size = label_size)
+    df
+  }
+
+  testthat::with_mocked_bindings(
+    {
+      annotate_lineplot_df(gg_plt = p_valid, data = mock_adlb, font_size = 14)
+    },
+    df2gg_aligned = mock_df2gg
+  )
+
+  expect_equal(captured$label_size, 14)
+  expect_equal(captured$text_size, 14 / ggplot2::.pt)
+})

man/annotate_pkc_df.Rd

@@ -201,3 +201,54 @@ test_that("annotate_pkc_df formats numeric digits correctly", {
   # Check 'sd' has a decimal point followed by EXACTLY 2 digits (e.g., "12.34")
   expect_true(grepl("\\.[0-9]{2}$", val_sd))
 })
+
+test_that("annotate_pkc_df forwards font_size to df2gg_aligned", {
+  df_pk <- data.frame(
+    time = rep(c(0, 1, 2), each = 4),
+    conc = runif(12, 10, 100),
+    arm = rep(c("Cohort A", "Cohort B"), times = 6)
+  )
+  p <- gg_pkc_lineplot(
+    data = df_pk, time_var = time, analyte_var = conc, group = arm, log_y = FALSE
+  )
+
+  captured <- NULL
+  mock_df2gg <- function(df, ..., text_size) {
+    captured <<- text_size
+    df
+  }
+
+  testthat::with_mocked_bindings(
+    annotate_pkc_df(gg_plt = p, data = df_pk, font_size = 14),
+    df2gg_aligned = mock_df2gg
+  )
+
+  expect_equal(captured, 14 / ggplot2::.pt)
+})
+
+test_that("annotate_pkc_df soft-deprecates text_size but keeps behaviour", {
+  df_pk <- data.frame(
+    time = rep(c(0, 1, 2), each = 4),
+    conc = runif(12, 10, 100),
+    arm = rep(c("Cohort A", "Cohort B"), times = 6)
+  )
+  p <- gg_pkc_lineplot(
+    data = df_pk, time_var = time, analyte_var = conc, group = arm, log_y = FALSE
+  )
+
+  captured <- NULL
+  mock_df2gg <- function(df, ..., text_size) {
+    captured <<- text_size
+    df
+  }
+
+  # text_size is passed through unchanged (round-trips via font_size)
+  lifecycle::expect_deprecated(
+    testthat::with_mocked_bindings(
+      annotate_pkc_df(gg_plt = p, data = df_pk, text_size = 5),
+      df2gg_aligned = mock_df2gg
+    )
+  )
+
+  expect_equal(captured, 5)
+})