From e5d5e6b45863ee0bd087332964eaf5760793679f Mon Sep 17 00:00:00 2001 From: Bram Kragten Date: Thu, 13 Aug 2026 12:44:05 +0200 Subject: [PATCH 1/2] Bump pnmp in E2E tests --- .github/renovate.json | 15 +++++++++++++++ tests/e2e/package.json | 2 +- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/.github/renovate.json b/.github/renovate.json index 08b017c21e2a9..ff67f490f7d6b 100644 --- a/.github/renovate.json +++ b/.github/renovate.json @@ -7,10 +7,13 @@ "pip_requirements", "pre-commit", "dockerfile", + "npm", "custom.regex", "homeassistant-manifest" ], + "ignorePaths": ["**/node_modules/**"], + "pre-commit": { "enabled": true }, @@ -26,6 +29,10 @@ "managerFilePatterns": ["/^Dockerfile$/"] }, + "npm": { + "managerFilePatterns": ["/^tests/e2e/package\\.json$/"] + }, + "homeassistant-manifest": { "managerFilePatterns": [ "/^homeassistant/components/[^/]+/manifest\\.json$/" @@ -180,6 +187,14 @@ "enabled": true, "labels": ["dependency"] }, + { + "description": "pnpm version pinned in the E2E tests packageManager field (allowlisted)", + "matchManagers": ["npm"], + "matchDepTypes": ["packageManager"], + "matchPackageNames": ["pnpm"], + "enabled": true, + "labels": ["dependency"] + }, { "description": "For types-* stubs, only allow patch updates. Major/minor bumps track the upstream runtime package version and must be manually coordinated with the corresponding pin.", "matchPackageNames": ["/^types-/"], diff --git a/tests/e2e/package.json b/tests/e2e/package.json index bb69b43f05bd7..0e2d348a9ac17 100644 --- a/tests/e2e/package.json +++ b/tests/e2e/package.json @@ -3,7 +3,7 @@ "version": "1.0.0", "description": "End-to-end browser tests for Home Assistant Core", "private": true, - "packageManager": "pnpm@11.13.0", + "packageManager": "pnpm@11.21.0", "scripts": { "test": "playwright test" }, From a86e5abfe85c3b30301afcd44a1ca2a2554e4700 Mon Sep 17 00:00:00 2001 From: Bram Kragten Date: Thu, 13 Aug 2026 13:22:24 +0200 Subject: [PATCH 2/2] Scope Renovate pnpm allowlist to the E2E package.json managerFilePatterns is additive to the npm manager's default patterns rather than restrictive, so the npm block did not limit anything: a future package.json elsewhere in the repo would have had its pnpm packageManager pin managed too. Drop the no-op block and enforce the scope with matchFileNames on the allowlist rule instead. Co-Authored-By: Claude Opus 5 --- .github/renovate.json | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/renovate.json b/.github/renovate.json index ff67f490f7d6b..ff8501778252c 100644 --- a/.github/renovate.json +++ b/.github/renovate.json @@ -29,10 +29,6 @@ "managerFilePatterns": ["/^Dockerfile$/"] }, - "npm": { - "managerFilePatterns": ["/^tests/e2e/package\\.json$/"] - }, - "homeassistant-manifest": { "managerFilePatterns": [ "/^homeassistant/components/[^/]+/manifest\\.json$/" @@ -190,6 +186,7 @@ { "description": "pnpm version pinned in the E2E tests packageManager field (allowlisted)", "matchManagers": ["npm"], + "matchFileNames": ["tests/e2e/package.json"], "matchDepTypes": ["packageManager"], "matchPackageNames": ["pnpm"], "enabled": true,