Skip to content

Hypercore.createProtocolStream(protomux) returns NoiseSteam, not the raw stream #448

Description

@gmaclennan

Hypercore.createProtocolStream() has slightly different behaviour when you pass it a Protomux instance instead of a raw duplex stream or a noise stream: in the latter cases it returns the raw outer stream (e.g. the noiseStream.rawStream), but when you pass a protomux instance it returns the noise stream. Not something that comes up much, but it's confusing.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions