Skip to content

Matminer continuing maintenance #960

Description

@esoteric-ephemera

Tagging @computron and @ZKC19940412 per earlier discussions:

  • Creating a namespace matminer.base package which just leverages the basic features needed in the MP stack. AFAIK, this is just BaseFeaturizer
  • Namespaces for the rest of matminer
  • PymatgenTest is deprecated and will need to be replaced with pytest-style tests. The removal date is overdue
  • Checking for pandas>=3.0 support
  • Transfer all legacy pymatgen.ext.matproj.MPRester calls to mp_api.client.MPRester

Since there's really only one class from matminer that's needed in the MP stack (see related emmet PR), it seems a bit unnecessary to make a separate namespace. Perhaps there are other options?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions