Skip to content

Concern about formula used in Compute_gamma_radii() in the WenAlloys() class #952

Description

@KwamiAldo

Dear maintainers,

I hope you are well.

I would like to raise a concern about the implementation of compute_gamma_radii() in the WenAlloys class of Matminer.
Specifically, it seems that:
The formula implemented in the code does not match the formula shown in the docstring.
Neither the implemented formula nor the docstring formula aligns with the formula described in the paper by Wen et al. or the original proposition (https://doi.org/10.1016/j.scriptamat.2014.09.010).

Could you clarify whether there is a specific reason for this difference?
Or is this a discrepancy that should be addressed?

Thank you very much for your time, and for the excellent work on Matminer.

Best regards,
Aldo

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions