Commit e86c905
committed
fix: CLI error hints for wait combinator failures
- Item 1 (preserve request headers across the 401-retry loop): the sync
client now delegates entirely to the async client, and the async
retry loop on this branch already rebuilds the retried request with
its original headers. Kept branch version.
- Item 7 (clear Windows readonly attr before rewriting the auth cache):
this branch reworked set_file_permissions to a Unix-only 0o600 path
with a no-op elsewhere, so no readonly attribute is ever set and the
clear_readonly helper is moot. Kept branch version.
- Item 33 (safe downcast of the reused ConfirmPopup): this branch
already replaced the raw-pointer downcast with Component::as_any_mut()
(as a required method returning &mut dyn Any). Kept branch version.
- Item 39 (variant-specific color_eyre suggestion for WaitTimeout /
WaitFailed / WaitResourceVanished): applied. Adds
OpenStackCliError::wait_hint (cli/core/src/error.rs), wired into
osc.rs so wait errors surface an actionable hint instead of
ApiError's generic transparent Display.
Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>1 parent f9c2b96 commit e86c905
2 files changed
Lines changed: 31 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
216 | 216 | | |
217 | 217 | | |
218 | 218 | | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
219 | 241 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| 25 | + | |
25 | 26 | | |
26 | 27 | | |
27 | 28 | | |
| |||
37 | 38 | | |
38 | 39 | | |
39 | 40 | | |
40 | | - | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
41 | 49 | | |
42 | 50 | | |
43 | 51 | | |
| |||
0 commit comments