Conversation
emadolsky
force-pushed
the
emadolsky/implement-multi-part-upload-for-large-objects
branch
from
February 19, 2025 13:57
81a5c57 to
d2803f8
Compare
We have observed that bloom blocks are sometimes larger than the S3 single part size limit (5GB) which causes failure in putting the blocks in S3. This commit adds the functionality to use multi-part upload only if the size is larger than the limit.
emadolsky
force-pushed
the
emadolsky/implement-multi-part-upload-for-large-objects
branch
from
February 19, 2025 13:59
d2803f8 to
e6a3c59
Compare
Contributor
Author
|
Hey @chaudum! Could you please have a look at this? |
Contributor
|
Since bloom filters are experimental and will be removed with the next major Loki release, I consider this feature as not relevant any more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We have observed that bloom blocks are sometimes larger than the S3 single part size limit (5GB) which causes failure in putting the blocks in S3. This commit adds the functionality to use multi-part upload only if the size is larger than the limit.
Which issue(s) this PR fixes:
Fixes #13444
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR