From d6cfa952b523811a61f5d68c8305293da9a17580 Mon Sep 17 00:00:00 2001 From: Curtis Conard Date: Thu, 3 Sep 2026 19:13:51 -0400 Subject: [PATCH 1/2] kb fix modifying child aside data instead of just current article --- js/modules/Knowbase/ArticleController.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/js/modules/Knowbase/ArticleController.js b/js/modules/Knowbase/ArticleController.js index 1a3f91f23b1d..26a44fcc5d19 100644 --- a/js/modules/Knowbase/ArticleController.js +++ b/js/modules/Knowbase/ArticleController.js @@ -579,7 +579,7 @@ export class GlpiKnowbaseArticleController const aside = document.querySelector('[data-main-page-aside="knowbaseitem"]'); const entries = aside.querySelectorAll( - `[data-glpi-kb-article-id="${CSS.escape(String(this.#item_id))}"] [data-glpi-kb-article-title]` + `[data-glpi-kb-article-id="${CSS.escape(String(this.#item_id))}"] > .article-line [data-glpi-kb-article-title]` ); for (const entry of entries) { entry.textContent = title; @@ -598,7 +598,7 @@ export class GlpiKnowbaseArticleController const aside = document.querySelector('[data-main-page-aside="knowbaseitem"]'); const containers = aside.querySelectorAll( - `[data-glpi-kb-article-id="${CSS.escape(String(this.#item_id))}"] [data-glpi-kb-article-illustration]` + `[data-glpi-kb-article-id="${CSS.escape(String(this.#item_id))}"] > .article-line [data-glpi-kb-article-illustration]` ); // The illustration picker preview already holds a freshly rendered node From 0cb89d33bd80752e68883491f4217595bdd3e79b Mon Sep 17 00:00:00 2001 From: Curtis Conard Date: Sun, 6 Sep 2026 07:56:31 -0400 Subject: [PATCH 2/2] fix search result html structure --- templates/pages/tools/kb/aside_search_results.html.twig | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/templates/pages/tools/kb/aside_search_results.html.twig b/templates/pages/tools/kb/aside_search_results.html.twig index e11c51e67111..72a4d8a28c80 100644 --- a/templates/pages/tools/kb/aside_search_results.html.twig +++ b/templates/pages/tools/kb/aside_search_results.html.twig @@ -46,7 +46,8 @@ {% endif %} class="article" > - +
+ {% endif %} +
{% endfor %}