Commit 1ca9787
committed
Preserve isTerminal in Java fluent copies, add Node isTerminal wire tests
Resolves the rebase onto main where both sides added an eighth tool
option: main added metadata and this branch added isTerminal.
- Java ToolDefinition now carries metadata and isTerminal as separate
record components, keeps the seven- and eight-argument convenience
constructors, and threads isTerminal through every fluent copy method
so it is no longer dropped by .metadata()/.defer()/etc.
- Adds ToolDefinition.isTerminal(boolean) so lambda-defined tools can
set it, matching the other flags.
- Adds the missing Node regression tests asserting isTerminal is
forwarded on both session.create and session.resume, and omitted when
unset.
- Applies the repo rust formatter to the new is_terminal test.1 parent 756630b commit 1ca9787
3 files changed
Lines changed: 69 additions & 5 deletions
File tree
- java/src/main/java/com/github/copilot/rpc
- nodejs/test
- rust/src
Lines changed: 3 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
95 | 95 | | |
96 | 96 | | |
97 | 97 | | |
98 | | - | |
99 | | - | |
| 98 | + | |
100 | 99 | | |
101 | 100 | | |
102 | 101 | | |
| |||
393 | 392 | | |
394 | 393 | | |
395 | 394 | | |
396 | | - | |
397 | | - | |
| 395 | + | |
| 396 | + | |
398 | 397 | | |
399 | 398 | | |
400 | 399 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
714 | 714 | | |
715 | 715 | | |
716 | 716 | | |
| 717 | + | |
| 718 | + | |
| 719 | + | |
| 720 | + | |
| 721 | + | |
| 722 | + | |
| 723 | + | |
| 724 | + | |
| 725 | + | |
| 726 | + | |
| 727 | + | |
| 728 | + | |
| 729 | + | |
| 730 | + | |
| 731 | + | |
| 732 | + | |
| 733 | + | |
| 734 | + | |
| 735 | + | |
| 736 | + | |
| 737 | + | |
| 738 | + | |
| 739 | + | |
| 740 | + | |
| 741 | + | |
| 742 | + | |
| 743 | + | |
| 744 | + | |
| 745 | + | |
| 746 | + | |
| 747 | + | |
| 748 | + | |
| 749 | + | |
| 750 | + | |
| 751 | + | |
| 752 | + | |
| 753 | + | |
| 754 | + | |
| 755 | + | |
| 756 | + | |
| 757 | + | |
| 758 | + | |
| 759 | + | |
| 760 | + | |
| 761 | + | |
| 762 | + | |
| 763 | + | |
| 764 | + | |
| 765 | + | |
| 766 | + | |
| 767 | + | |
| 768 | + | |
| 769 | + | |
| 770 | + | |
| 771 | + | |
| 772 | + | |
| 773 | + | |
| 774 | + | |
| 775 | + | |
| 776 | + | |
| 777 | + | |
| 778 | + | |
717 | 779 | | |
718 | 780 | | |
719 | 781 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7547 | 7547 | | |
7548 | 7548 | | |
7549 | 7549 | | |
7550 | | - | |
| 7550 | + | |
| 7551 | + | |
| 7552 | + | |
| 7553 | + | |
7551 | 7554 | | |
7552 | 7555 | | |
7553 | 7556 | | |
| |||
0 commit comments