diff --git a/frontend/src/pages/ProfileRoles.vue b/frontend/src/pages/ProfileRoles.vue index 06f1260006..8002955d99 100644 --- a/frontend/src/pages/ProfileRoles.vue +++ b/frontend/src/pages/ProfileRoles.vue @@ -24,6 +24,7 @@ import { noRoles, type MemberRoleKey, } from '@/components/Settings/Members/members' +import { resourceErrorMessage } from '@/utils/resource' const roles = reactive(noRoles()) const readOnlyMode = window.read_only_mode @@ -55,14 +56,20 @@ watch( ) const onToggle = async (key: MemberRoleKey, value: boolean) => { - roles[key] = value const row = ROLE_ROWS.find((r) => r.key === key) if (!row) return - await call('lms.lms.api.save_role', { - user: props.profile.data?.name, - role: row.role, - value, - }) + roles[key] = value + try { + await call('lms.lms.api.save_role', { + user: props.profile.data?.name, + role: row.role, + value, + }) + } catch (error) { + roles[key] = !value + toast.error(resourceErrorMessage(error, __('Could not update the role'))) + return + } toast.success(__('Role updated successfully')) } diff --git a/lms/lms/api.py b/lms/lms/api.py index 63c0e23d7f..40c1596121 100644 --- a/lms/lms/api.py +++ b/lms/lms/api.py @@ -2958,6 +2958,9 @@ def check_can_manage_member(member: str): @frappe.whitelist(methods=["POST"]) def save_role(user: str, role: str, value: int): frappe.only_for("Moderator") + if not isinstance(user, str) or user in ("Administrator", "Guest") or not frappe.db.exists("User", user): + frappe.throw(_("Member {0} does not exist.").format(user), frappe.DoesNotExistError) + check_can_manage_member(user) if role not in LMS_ROLES: frappe.throw(_("You do not have permission to modify this role."), frappe.PermissionError)