From 1da8caa93e5179f9bc88b294fd8d54a7835dc3f1 Mon Sep 17 00:00:00 2001 From: Raizaaa <89463672+raizasafeel@users.noreply.github.com> Date: Mon, 16 Nov 2026 01:57:22 +0530 Subject: [PATCH 1/5] fix(rtl): flip directional icons and physical positioning in RTL Semgrep's tailwind-rtl gate only sees physical utility classes. This covers what it can't: prev/next and back chevrons, icons passed to frappe-ui as names (moved to slots), always-directional lucide icons mirrored in index.css, centred overlays built from start-1/2 -translate-x-1/2, the inline lesson menu and notification panel positioning, the audio played fill, and tooltip/dropdown sides through inlineStartSide/inlineEndSide. Co-Authored-By: Claude Opus 5.5 --- frontend/src/components/AudioBlock.vue | 9 +++++++++ frontend/src/components/Controls/Link.vue | 2 +- frontend/src/components/DiscussionReplies.vue | 4 +++- .../Enrollment/EnrollPaymentPanel.vue | 7 +++++-- frontend/src/components/InstallPrompt.vue | 2 +- .../components/Layouts/pages/PageHeader.vue | 2 +- .../Layouts/pages/mobile/MobilePageLayout.vue | 2 +- .../settings/desktop/SettingsHeader.vue | 7 +++++-- .../Layouts/settings/mobile/SettingsRow.vue | 2 +- frontend/src/components/LessonNavButtons.vue | 4 ++-- .../src/components/Modals/EditCoverImage.vue | 2 +- .../src/components/Notes/InlineLessonMenu.vue | 11 +++++++--- .../Notifications/NotificationPanel.vue | 7 ++++--- frontend/src/components/PdfBlock.vue | 10 +++++++--- .../src/components/Profile/ProfileAvatar.vue | 3 ++- .../src/components/Profile/ProfileCover.vue | 2 +- .../ProgrammingExercises/ExerciseConsole.vue | 4 +++- frontend/src/components/Setup/SetupInvite.vue | 7 +++++-- .../src/components/Sidebar/SidebarLink.vue | 3 ++- .../src/components/UnsplashImageBrowser.vue | 2 +- .../src/components/UpcomingEvaluations.vue | 3 ++- frontend/src/components/UserAvatar.vue | 5 +++-- frontend/src/index.css | 15 ++++++++++++++ .../pages/Batches/components/LiveClass.vue | 3 ++- frontend/src/pages/Courses/CourseDetail.vue | 4 ++-- frontend/src/pages/Home/LiveClassCard.vue | 3 ++- frontend/src/pages/Lesson.vue | 4 ++-- .../src/pages/ProfileEvaluationSchedule.vue | 18 +++++++++-------- frontend/src/pages/Programs/ProgramDetail.vue | 3 ++- frontend/src/pages/Setup.vue | 7 +++++-- frontend/src/tests/textDirection.test.ts | 20 +++++++++++++++++++ frontend/src/utils/textDirection.ts | 10 ++++++++++ 32 files changed, 138 insertions(+), 49 deletions(-) create mode 100644 frontend/src/tests/textDirection.test.ts create mode 100644 frontend/src/utils/textDirection.ts diff --git a/frontend/src/components/AudioBlock.vue b/frontend/src/components/AudioBlock.vue index 6e21b95ece..2dc34856e2 100644 --- a/frontend/src/components/AudioBlock.vue +++ b/frontend/src/components/AudioBlock.vue @@ -159,6 +159,15 @@ const formatTime = (time) => { cursor: pointer; } +/* A range input runs right to left in RTL; the played fill has to follow it. */ +[dir='rtl'] .audio-seek { + background: linear-gradient( + to left, + var(--ink-gray-9) var(--played), + var(--surface-gray-4) var(--played) + ); +} + .audio-seek::-webkit-slider-thumb { -webkit-appearance: none; width: 12px; diff --git a/frontend/src/components/Controls/Link.vue b/frontend/src/components/Controls/Link.vue index c3d8f431f9..20468dfa4f 100644 --- a/frontend/src/components/Controls/Link.vue +++ b/frontend/src/components/Controls/Link.vue @@ -33,7 +33,7 @@ :aria-label="__('Cancel')" @click="creating = false" > - + diff --git a/frontend/src/components/Enrollment/EnrollPaymentPanel.vue b/frontend/src/components/Enrollment/EnrollPaymentPanel.vue index 2117ecbcdd..52d5d91bb7 100644 --- a/frontend/src/components/Enrollment/EnrollPaymentPanel.vue +++ b/frontend/src/components/Enrollment/EnrollPaymentPanel.vue @@ -6,10 +6,13 @@ v-if="showBack" data-testid="payment-panel-back" variant="ghost" - icon="lucide-chevron-left" :aria-label="__('Back')" @click="emit('back')" - /> + > + +