Skip to content

mortie 1.0 floor bump: migrate retired call sites (arrow from_wkbs rename; shardmap fallback off morton_coverage_moc) #513

Description

@espg

🤖 from Claude

Filed at espg's direction (in-session 2026-08-24), from the mortie PR espg/mortie#195 question-6/7 rulings. mortie's API consolidation (merging soon; next mortie tag after it is 1.0.0) retires two names zagg calls today, so the zagg floor bump to mortie 1.0 carries two mechanical call-site migrations:

  1. src/zagg/catalog/sources.py:614/623from mortie.arrow import from_wkbsfrom_wkb (renamed under the one-name-per-operation invariant; the column-in batch shape is unchanged). Migration note from the mortie CHANGELOG: tolerance= must be passed as a keyword on the new spelling — never positionally (the third positional is now moc; mortie also grows a None/bool type refusal on moc that makes a positional float loud rather than silent).
  2. src/zagg/catalog/shardmap.py:383/395 — the per-ring fallback arm calls the retired scalar morton_coverage_moc(lats, lons, order=). Migrate to a surviving public route: polygons_to_morton_mocs on the single ring (the hot path one line up already uses it — likely the smallest diff), or the geometry route (from_geometry(..., moc=True)). Do NOT import the surviving private _morton_coverage_moc.
  3. Sweep docstrings/comments naming the retired spellings (shardmap.py:22/44/372/1048/1600, sources.py:574/609).

Gated on: mortie 1.0.0 release + the zagg pyproject.toml mortie floor bump (one PR: floor + both call sites + docstring sweep + tests green). No behavior change intended — pin parity between old and new call forms in the tests if practical.

Refs: espg/mortie#195 (retirement + rulings), espg/mortie#187, zagg PR #400 (the batch path), zagg PR #447 (the unindexed from_wkbs path).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions