From d7e2045174949e04f5842671ed00c88eaa648ddf Mon Sep 17 00:00:00 2001 From: simonge Date: Wed, 2 Sep 2026 17:35:45 +0100 Subject: [PATCH 1/4] Change FF LGAD resolution from 8ns to 30ps --- src/detectors/B0TRK/B0TRK.cc | 4 ++-- src/detectors/FOFFMTRK/FOFFMTRK.cc | 4 ++-- src/detectors/RPOTS/RPOTS.cc | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/detectors/B0TRK/B0TRK.cc b/src/detectors/B0TRK/B0TRK.cc index d7b53cc1fe..935bb6f641 100644 --- a/src/detectors/B0TRK/B0TRK.cc +++ b/src/detectors/B0TRK/B0TRK.cc @@ -25,7 +25,7 @@ void InitPlugin(JApplication* app) { {"B0TrackerRawHits", "B0TrackerRawHitLinks", "B0TrackerRawHitAssociations"}, { .threshold = 10.0 * dd4hep::keV, - .timeResolution = 8, + .timeResolution = 30 * dd4hep::picosecond, }, app)); @@ -33,7 +33,7 @@ void InitPlugin(JApplication* app) { app->Add(new JOmniFactoryGeneratorT( "B0TrackerRecHits", {"B0TrackerRawHits"}, {"B0TrackerRecHits"}, { - .timeResolution = 8, + .timeResolution = 30 * dd4hep::picosecond, }, app)); } diff --git a/src/detectors/FOFFMTRK/FOFFMTRK.cc b/src/detectors/FOFFMTRK/FOFFMTRK.cc index 5ff1a6d710..d932b1ed25 100644 --- a/src/detectors/FOFFMTRK/FOFFMTRK.cc +++ b/src/detectors/FOFFMTRK/FOFFMTRK.cc @@ -27,14 +27,14 @@ void InitPlugin(JApplication* app) { "ForwardOffMTrackerRawHitAssociations"}, { .threshold = 10.0 * dd4hep::keV, - .timeResolution = 8, + .timeResolution = 30 * dd4hep::picosecond, }, app)); app->Add(new JOmniFactoryGeneratorT( "ForwardOffMTrackerRecHits", {"ForwardOffMTrackerRawHits"}, {"ForwardOffMTrackerRecHits"}, { - .timeResolution = 8, + .timeResolution = 30 * dd4hep::picosecond, }, app)); diff --git a/src/detectors/RPOTS/RPOTS.cc b/src/detectors/RPOTS/RPOTS.cc index c28d68e920..d996adf113 100644 --- a/src/detectors/RPOTS/RPOTS.cc +++ b/src/detectors/RPOTS/RPOTS.cc @@ -31,14 +31,14 @@ void InitPlugin(JApplication* app) { {"ForwardRomanPotRawHits", "ForwardRomanPotRawHitLinks", "ForwardRomanPotRawHitAssociations"}, { .threshold = 10.0 * dd4hep::keV, - .timeResolution = 8, + .timeResolution = 30 * dd4hep::picosecond, }, app)); app->Add(new JOmniFactoryGeneratorT( "ForwardRomanPotRecHits", {"ForwardRomanPotRawHits"}, {"ForwardRomanPotRecHits"}, { - .timeResolution = 8, + .timeResolution = 30 * dd4hep::picosecond, }, app)); From c0b709ac397375f689627fa12dfa7589ab06fa2a Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Wed, 2 Sep 2026 16:41:59 +0000 Subject: [PATCH 2/4] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- src/detectors/RPOTS/RPOTS.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/detectors/RPOTS/RPOTS.cc b/src/detectors/RPOTS/RPOTS.cc index d996adf113..2785f5d427 100644 --- a/src/detectors/RPOTS/RPOTS.cc +++ b/src/detectors/RPOTS/RPOTS.cc @@ -31,7 +31,7 @@ void InitPlugin(JApplication* app) { {"ForwardRomanPotRawHits", "ForwardRomanPotRawHitLinks", "ForwardRomanPotRawHitAssociations"}, { .threshold = 10.0 * dd4hep::keV, - .timeResolution = 30 * dd4hep::picosecond, + .timeResolution = 30 * dd4hep::picosecond, }, app)); From a4b9c7211913cdc8656b4aa843287a2055247157 Mon Sep 17 00:00:00 2001 From: simonge Date: Wed, 2 Sep 2026 22:05:23 +0100 Subject: [PATCH 3/4] Change to edm4eic units --- src/detectors/B0TRK/B0TRK.cc | 5 +++-- src/detectors/FOFFMTRK/FOFFMTRK.cc | 5 +++-- src/detectors/RPOTS/RPOTS.cc | 5 +++-- 3 files changed, 9 insertions(+), 6 deletions(-) diff --git a/src/detectors/B0TRK/B0TRK.cc b/src/detectors/B0TRK/B0TRK.cc index 935bb6f641..9d35952cd4 100644 --- a/src/detectors/B0TRK/B0TRK.cc +++ b/src/detectors/B0TRK/B0TRK.cc @@ -8,6 +8,7 @@ #include #include #include +#include #include "extensions/jana/JOmniFactoryGeneratorT.h" #include "factories/digi/SiliconTrackerDigi_factory.h" @@ -25,7 +26,7 @@ void InitPlugin(JApplication* app) { {"B0TrackerRawHits", "B0TrackerRawHitLinks", "B0TrackerRawHitAssociations"}, { .threshold = 10.0 * dd4hep::keV, - .timeResolution = 30 * dd4hep::picosecond, + .timeResolution = 30 * edm4eic::unit::ps, }, app)); @@ -33,7 +34,7 @@ void InitPlugin(JApplication* app) { app->Add(new JOmniFactoryGeneratorT( "B0TrackerRecHits", {"B0TrackerRawHits"}, {"B0TrackerRecHits"}, { - .timeResolution = 30 * dd4hep::picosecond, + .timeResolution = 30 * edm4eic::unit::ps, }, app)); } diff --git a/src/detectors/FOFFMTRK/FOFFMTRK.cc b/src/detectors/FOFFMTRK/FOFFMTRK.cc index d932b1ed25..2bbf035a86 100644 --- a/src/detectors/FOFFMTRK/FOFFMTRK.cc +++ b/src/detectors/FOFFMTRK/FOFFMTRK.cc @@ -8,6 +8,7 @@ #include #include #include +#include #include "algorithms/fardetectors/MatrixTransferStaticConfig.h" #include "extensions/jana/JOmniFactoryGeneratorT.h" @@ -27,14 +28,14 @@ void InitPlugin(JApplication* app) { "ForwardOffMTrackerRawHitAssociations"}, { .threshold = 10.0 * dd4hep::keV, - .timeResolution = 30 * dd4hep::picosecond, + .timeResolution = 30 * edm4eic::unit::ps, }, app)); app->Add(new JOmniFactoryGeneratorT( "ForwardOffMTrackerRecHits", {"ForwardOffMTrackerRawHits"}, {"ForwardOffMTrackerRecHits"}, { - .timeResolution = 30 * dd4hep::picosecond, + .timeResolution = 30 * edm4eic::unit::ps, }, app)); diff --git a/src/detectors/RPOTS/RPOTS.cc b/src/detectors/RPOTS/RPOTS.cc index 2785f5d427..9fc3e29e32 100644 --- a/src/detectors/RPOTS/RPOTS.cc +++ b/src/detectors/RPOTS/RPOTS.cc @@ -8,6 +8,7 @@ #include #include #include +#include #include "algorithms/fardetectors/MatrixTransferStaticConfig.h" #include "algorithms/fardetectors/PolynomialMatrixReconstructionConfig.h" @@ -31,14 +32,14 @@ void InitPlugin(JApplication* app) { {"ForwardRomanPotRawHits", "ForwardRomanPotRawHitLinks", "ForwardRomanPotRawHitAssociations"}, { .threshold = 10.0 * dd4hep::keV, - .timeResolution = 30 * dd4hep::picosecond, + .timeResolution = 30 * edm4eic::unit::ps, }, app)); app->Add(new JOmniFactoryGeneratorT( "ForwardRomanPotRecHits", {"ForwardRomanPotRawHits"}, {"ForwardRomanPotRecHits"}, { - .timeResolution = 30 * dd4hep::picosecond, + .timeResolution = 30 * edm4eic::unit::ps, }, app)); From 5788c1ba70ecd343dabf4d5e60254b6acc4d5f3e Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Wed, 2 Sep 2026 21:07:32 +0000 Subject: [PATCH 4/4] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- src/detectors/RPOTS/RPOTS.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/detectors/RPOTS/RPOTS.cc b/src/detectors/RPOTS/RPOTS.cc index 9fc3e29e32..e0cbb06f1b 100644 --- a/src/detectors/RPOTS/RPOTS.cc +++ b/src/detectors/RPOTS/RPOTS.cc @@ -32,7 +32,7 @@ void InitPlugin(JApplication* app) { {"ForwardRomanPotRawHits", "ForwardRomanPotRawHitLinks", "ForwardRomanPotRawHitAssociations"}, { .threshold = 10.0 * dd4hep::keV, - .timeResolution = 30 * edm4eic::unit::ps, + .timeResolution = 30 * edm4eic::unit::ps, }, app));