Repository navigation
Replace 'spacing.labelNode' with 'nodeLabels.margin' #576
Description
Consider
// TODO only applied to outside labels?
spacing.labelNode: 30
nodeLabels.padding: "[top=10.0,left=10.0,bottom=10.0,right=10.0]"
node n3 {
nodeLabels.placement: "H_CENTER V_TOP INSIDE"
label "label1"
label "label2"
}
node n4 {
nodeLabels.placement: "H_CENTER V_TOP OUTSIDE"
label "label1"
label "label2"
}
which yields
The labelNode is only applied to the OUTSIDE labels, while padding is used on the inside. @le-cds is it possible that labelNode is partly deprecated in this case after your node label placement changes?
Maybe it's reasonable to replace the labelNode by a new margins property for the outside?
Activity
le-cds commentedon Apr 24, 2020
Sure, we could replace the label-node spacing by margins, which would be configurable for all four sides independently.
You don't see a bug here, do you? I'd consider this expected behaviour?
uruuru commentedon Apr 24, 2020
Not a bug but inconsistent behavior I'd say.
If we were introduce
nodeLabels.margins,spacing.nodeLabelwould be obsolete, wouldn't it? In that case we shouldpaddingandmarginwithnodeLabel.I kind of like b) since that would preserve the possibility to control all spacings using the
spacinggroup.le-cds commentedon Apr 24, 2020
Ah, I see why you find it inconsistent.
Absolutely. I guess I'd simply remove it. The spacing options are already way too complex...
core: #576 turned 'spacing.labelNode' into 'nodeLabels.margin'
layered: #576 adjustment after 'labelNode' removal
core.nodespacing: #576 adjusted NodeMarginCalculator
core.nodespacing: #576 further adjustments
uruuru commentedon Jun 18, 2020
Feel free to participate in the PR :).
[-]Spacing labelNode not applied[/-][+]Replace 'spacing.labelNode' with 'nodeLabels.margin' [/+]