From 6b6f410eab8f3451f67e787ebe4d5413aae31ed8 Mon Sep 17 00:00:00 2001 From: Alexander Grund Date: Fri, 7 Aug 2026 13:03:47 +0200 Subject: [PATCH] Remove superflous check `self.is_extension` is already checked so cleanup condition and clarify in comments. Followup to #5220 --- easybuild/framework/easyblock.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/easybuild/framework/easyblock.py b/easybuild/framework/easyblock.py index 148e037147..1c82d7c430 100644 --- a/easybuild/framework/easyblock.py +++ b/easybuild/framework/easyblock.py @@ -4382,6 +4382,7 @@ def sanity_check_load_module(self, extension=None, extra_modules=None): f'Should be: {self.is_extension}, got: {extension}') del extension # Avoid accidental use + # Don't load any module for extensions if self.is_extension: return self.fake_mod_data @@ -4390,8 +4391,7 @@ def sanity_check_load_module(self, extension=None, extra_modules=None): self.log.info("Loading real module for %s %s: %s", self.name, self.version, self.short_mod_name) self.load_module(extra_modules=extra_modules) self.sanity_check_module_loaded = True - # only load fake module for non-extensions, and not during dry run - elif not (self.is_extension or self.dry_run): + elif not self.dry_run: if extra_modules: self.log.info("Loading extra modules for sanity check: %s", ', '.join(extra_modules)) try: