Repository navigation
fix(squads): create a Startups company without a description - #7290
Merged
Merged
Conversation
The company step sends description '', which the API rejects (description is invalid), so Continue did nothing. Leave an empty description out of CreateSquad, and show the default error toast when the API error isn't about the handle. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FodmVu511cm42Xwnsvau3u
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ido · project thread
Changes
Found in the end-to-end test of the daily.dev for Startups checkout: on the Company step, Continue did nothing.
description: ''. The API validates description against^[\S\s]{1,250}$, so it answers{"description":"description is invalid!"}and no squad is created.createSquadnow leaves an empty description out of theCreateSquadvariables. Creating a squad with a description is unchanged, and so is editing.useSquadCreateshowedresult.handleas the toast for any validation error, so this failure showed an empty toast. It now falls back to the default error message when the error isn't about the handle.Events
No.
Experiment
No.
Manual Testing
Ran typecheck and lint on the changed files, plus the squad and checkout Jest suites (8 suites, 35 tests pass). The only typecheck error is in
ArchiveFeedPage.spec.tsxand was already on main. After deploy, the e2e run resumes from the Company step on production.Generated by Claude Code
Preview domain
https://fix-startups-company-empty-descr.preview.app.daily.dev