[format] Build fresh ORC writer options per created writer (#9583)

Author: LuciferYang

paimon-format/src/main/java/org/apache/paimon/format/orc/OrcWriterFactory.java

@@ -62,8 +62,6 @@ public class OrcWriterFactory implements FormatWriterFactory, SupportsShreddingW
     private final Properties writerProperties;
     private final Map<String, String> confMap;
     private final boolean legacyTimestampLtzType;
-
-    private OrcFile.WriterOptions writerOptions;
     private final int writeBatchSize;
     private final MemorySize writeBatchMemory;
 
@@ -169,11 +167,10 @@ public void commitShreddingMetadata(
 
     @VisibleForTesting
     protected OrcFile.WriterOptions getWriterOptions() {
-        if (null == writerOptions) {
-            writerOptions = OrcFile.writerOptions(writerProperties, configuration());
-            writerOptions.setSchema(this.vectorizer.getSchema());
-        }
-
+        // create() writes per-file state into the returned options, so it cannot be cached.
+        OrcFile.WriterOptions writerOptions =
+                OrcFile.writerOptions(writerProperties, configuration());
+        writerOptions.setSchema(this.vectorizer.getSchema());
         return writerOptions;
     }
 

paimon-format/src/test/java/org/apache/paimon/format/orc/OrcWriterFactoryTest.java

@@ -35,6 +35,7 @@
 import java.io.IOException;
 import java.util.ArrayList;
 import java.util.Arrays;
+import java.util.Collections;
 import java.util.List;
 
 import static org.apache.paimon.utils.Preconditions.checkNotNull;
@@ -99,4 +100,17 @@ public void removeWriter(Path path) {}
         @Override
         public void addedRow(int rows) {}
     }
+
+    @Test
+    void testWriterOptionsNotSharedBetweenCalls() {
+        // create() writes per-file state into the options, so each caller needs its own.
+        OrcWriterFactory factory =
+                new OrcWriterFactory(
+                        new RowDataVectorizer(
+                                TypeDescription.createString(),
+                                Collections.singletonList(
+                                        new DataField(0, "f0", DataTypes.STRING())),
+                                false));
+        assertThat(factory.getWriterOptions()).isNotSameAs(factory.getWriterOptions());
+    }
 }